You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/02 05:06:51 UTC
[GitHub] [helix] pkuwm opened a new pull request #1205: Fix mvn site failure
pkuwm opened a new pull request #1205:
URL: https://github.com/apache/helix/pull/1205
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1203
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
mvn site fails because of java.lang.NoClassDefFoundError: org/sonatype/aether/graph/DependencyFilter.
Fix: upgrade maven-site-plugin with latest one that fixes the issue.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
```
mvn site
[INFO] Rendering site with default locale English (en)
[INFO] Relativizing decoration links with respect to localized project URL: http://helix.apache.org/recipes/service-discovery
[INFO] Rendering content with org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
[INFO] Generating "Source Xref" report --- maven-jxr-plugin:3.0.0:jxr
[INFO] Generating "CI Management" report --- maven-project-info-reports-plugin:3.0.0:ci-management
[INFO] Generating "Dependencies" report --- maven-project-info-reports-plugin:3.0.0:dependencies
[INFO] Generating "Dependency Information" report --- maven-project-info-reports-plugin:3.0.0:dependency-info
[INFO] Generating "Dependency Management" report --- maven-project-info-reports-plugin:3.0.0:dependency-management
[INFO] Generating "Distribution Management" report --- maven-project-info-reports-plugin:3.0.0:distribution-management
[INFO] Generating "About" report --- maven-project-info-reports-plugin:3.0.0:index
[INFO] Generating "Issue Management" report --- maven-project-info-reports-plugin:3.0.0:issue-management
[INFO] Generating "Licenses" report --- maven-project-info-reports-plugin:3.0.0:licenses
[INFO] Generating "Mailing Lists" report --- maven-project-info-reports-plugin:3.0.0:mailing-lists
[INFO] Generating "Plugin Management" report --- maven-project-info-reports-plugin:3.0.0:plugin-management
[INFO] Generating "Plugins" report --- maven-project-info-reports-plugin:3.0.0:plugins
[INFO] Generating "Source Code Management" report --- maven-project-info-reports-plugin:3.0.0:scm
[INFO] Generating "Summary" report --- maven-project-info-reports-plugin:3.0.0:summary
[INFO] Generating "Team" report --- maven-project-info-reports-plugin:3.0.0:team
[INFO] Generating "Sonar" report --- maven-report:0.1:report
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 33.068 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 1.492 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 2.403 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 2.515 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 2.167 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 5.449 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 3.365 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 4.378 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 2.213 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 2.533 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.554 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 2.887 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 2.545 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 2.425 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 2.561 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 2.250 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 min
[INFO] Finished at: 2020-08-01T22:02:48-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464595451
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
`doxia-module-markdown` is not a direct dependency in maven-site-plugin 3.2, but it is a dependency in 3.9.1.
https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-site-plugin/3.9.1
So I think it is fine to remove this dependency. And as I tested it, website htmls are fine. Maybe I have't checked the broken website htmls you talk about. If you could tell me what htmls are broken, I could test to verify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464209419
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
There is a reason why we keep the doxia plugin at 3.2. I've attempted to upgrade the doxia plugin to the latest a while ago, and although you see the mvn site command pass, it will end up generating a broken website due to backward-incompatibility issues with the plugin.
Did you test it by creating and inspecting the resulting website htmls? Is this a blocker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464209419
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
There is a reason why we keep the doxia plugin at 3.2. I've attempted to upgrade the doxia plugin to the latest a while ago, and although you see the mvn site command pass, it will end up generating a broken website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
pkuwm closed pull request #1205:
URL: https://github.com/apache/helix/pull/1205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464209419
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
There is a reason why we keep the doxia plugin at 3.2. I've attempted to upgrade the doxia plugin to the latest a while ago, and although you see the mvn site command pass, it will end up generating a broken website due to backward-incompatibility issues with the plugin.
Did you test it by creating and inspecting the resulting website htmls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1205: Fix mvn site failure
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464595451
##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.2</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.maven.doxia</groupId>
- <artifactId>doxia-module-markdown</artifactId>
- <version>1.3</version>
- </dependency>
- </dependencies>
+ <version>3.9.1</version>
Review comment:
`doxia-module-markdown` is not a direct dependency in maven-site-plugin 3.2, but it is a dependency in 3.9.1.
https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-site-plugin/3.9.1
So I think it is fine to remove this dependency. And as I tested it, website htmls are fine. Maybe I have't checked the broken website htmls you talk about. If you could tell me what htmls are broken, I could test to verify.
I did test it by creating and inspecting the site htmls. This is an issue because mvn site fails so we could not generate htmls to test our changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org