You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/04/10 21:52:43 UTC
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12989
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
This patch adds a test coverage for running Impala with Ranger on local
catalog mode to make sure there is no regression introduced in local
catlaog when running Impala with Ranger.
Testing:
- Added missing E2E test in test_ranger.py
Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
---
M tests/authorization/test_ranger.py
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/12989/1
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py@39
PS2, Line 39: --server-name=server1 --ranger_service_type=hive "
: "--ranger_app_id=impala "
: "--authorization_factory_class="
: "org.apache.impala.authorization.ranger.RangerAuthorizationFactory
nit: define strings for all the config boiler plate? Used thrice in this file.
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 01:27:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
This patch adds a test coverage for running Impala with Ranger on local
catalog mode to make sure there is no regression introduced in local
catlaog when running Impala with Ranger.
Testing:
- Added missing E2E test in test_ranger.py
Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Reviewed-on: http://gerrit.cloudera.org:8080/12989
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/authorization/test_ranger.py
1 file changed, 23 insertions(+), 17 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 3: Code-Review+2
Carry Bharath's +2.
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:10:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
This patch adds a test coverage for running Impala with Ranger on local
catalog mode to make sure there is no regression introduced in local
catlaog when running Impala with Ranger.
Testing:
- Added missing E2E test in test_ranger.py
Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
---
M tests/authorization/test_ranger.py
1 file changed, 23 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/12989/3
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2727/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:35:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2728/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Apr 2019 22:39:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2738/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:55:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
This patch adds a test coverage for running Impala with Ranger on local
catalog mode to make sure there is no regression introduced in local
catlaog when running Impala with Ranger.
Testing:
- Added missing E2E test in test_ranger.py
Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
---
M tests/authorization/test_ranger.py
1 file changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/12989/2
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4011/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:10:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:10:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 21:20:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py@39
PS2, Line 39: ustomClusterTestSuite):
: """
: Tests for Apache Ranger integration with Apache Impala.
: """
> nit: define strings for all the config boiler plate? Used thrice in this fi
Done
--
To view, visit http://gerrit.cloudera.org:8080/12989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b
Gerrit-Change-Number: 12989
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 16:09:49 +0000
Gerrit-HasComments: Yes