You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/24 05:08:16 UTC
[GitHub] [incubator-seatunnel] zhangbutao opened a new pull request #1148: [Doc] Fix incorrect description for spark conf template doc
zhangbutao opened a new pull request #1148:
URL: https://github.com/apache/incubator-seatunnel/pull/1148
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Fix incorrect description for spark conf template doc
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1148: [Doc] Fix incorrect description for spark conf template doc
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1148:
URL: https://github.com/apache/incubator-seatunnel/pull/1148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhangbutao commented on a change in pull request #1148: [Doc] Fix incorrect description for spark conf template doc
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on a change in pull request #1148:
URL: https://github.com/apache/incubator-seatunnel/pull/1148#discussion_r790421666
##########
File path: config/spark.batch.conf.template
##########
@@ -36,8 +36,8 @@ source {
- # You can also use other input plugins, such as hdfs
- # hdfs {
+ # You can also use other input plugins, such as file
+ # file {
Review comment:
Firstly, there is no source named hdfs in current seatunnel-spark connector. And file source also support hdfs、aws 、oss protocol because it use hdfs client internally. Please correct me if I am wrong. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] SteNicholas commented on a change in pull request #1148: [Doc] Fix incorrect description for spark conf template doc
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #1148:
URL: https://github.com/apache/incubator-seatunnel/pull/1148#discussion_r790418226
##########
File path: config/spark.batch.conf.template
##########
@@ -36,8 +36,8 @@ source {
- # You can also use other input plugins, such as hdfs
- # hdfs {
+ # You can also use other input plugins, such as file
+ # file {
Review comment:
Why do you change this? Does other file system like OSS support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] SteNicholas commented on a change in pull request #1148: [Doc] Fix incorrect description for spark conf template doc
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #1148:
URL: https://github.com/apache/incubator-seatunnel/pull/1148#discussion_r790418226
##########
File path: config/spark.batch.conf.template
##########
@@ -36,8 +36,8 @@ source {
- # You can also use other input plugins, such as hdfs
- # hdfs {
+ # You can also use other input plugins, such as file
+ # file {
Review comment:
Why do you change this? Does other file system like OSS support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org