[GitHub] [yunikorn-core] lowc1012 commented on a diff in pull request #437: [YUNIKORN-1319] expose reservation info in application rest endpoints

[GitBox <gi...@apache.org>]

lowc1012 commented on code in PR #437:
URL: https://github.com/apache/yunikorn-core/pull/437#discussion_r973051429


##########
pkg/webservice/handlers_test.go:
##########
@@ -1068,6 +1068,12 @@ func TestGetQueueApplicationsHandler(t *testing.T) {
 	assert.NilError(t, err, "failed to unmarshal applications dao response from response body: %s", string(resp.outputBytes))
 	assert.Equal(t, len(appsDao), 2)
 
+	if !appsDao[0].HasReserved {
+		assert.Equal(t, len(appsDao[0].Reservations), 0)
+	} else {
+		assert.Check(t, len(appsDao[0].Reservations) > 0, "Get wrong reservation info from apps dao")

Review Comment:
   Thanks! It makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org