You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2021/01/11 14:53:52 UTC
[commons-geometry] branch master updated: Minor Performance
Improvement:
This is an automated email from the ASF dual-hosted git repository.
mattjuntunen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
The following commit(s) were added to refs/heads/master by this push:
new b097ec4 Minor Performance Improvement:
b097ec4 is described below
commit b097ec49978b9d2187acddd3516d98002d510686
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Wed Jan 6 12:59:27 2021 +0100
Minor Performance Improvement:
* avoid Add Empty String
* Redundant Field Initializer
* Append Character With Char
---
.../commons/geometry/core/partitioning/bsp/AbstractBSPTree.java | 2 +-
.../commons/geometry/core/internal/IteratorTransformTest.java | 6 +++---
.../apache/commons/geometry/core/partitioning/bsp/MergeChecker.java | 4 ++--
.../java/org/apache/commons/geometry/euclidean/threed/Planes.java | 2 +-
.../commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java | 4 ++--
.../org/apache/commons/geometry/euclidean/twod/path/LinePath.java | 4 ++--
.../org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java | 2 +-
.../geometry/hull/euclidean/twod/AbstractConvexHullGenerator2D.java | 2 +-
.../org/apache/commons/geometry/spherical/oned/Transform1S.java | 2 +-
.../java/org/apache/commons/geometry/spherical/twod/GreatArc.java | 3 +--
.../org/apache/commons/geometry/spherical/twod/GreatArcPath.java | 6 +++---
.../org/apache/commons/geometry/spherical/twod/Transform2S.java | 2 +-
12 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
index f7b33ea..fc3c37b 100644
--- a/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
+++ b/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java
@@ -200,7 +200,7 @@ public abstract class AbstractBSPTree<P extends Point<P>, N extends AbstractBSPT
.append(count())
.append(", height= ")
.append(height())
- .append("]")
+ .append(']')
.toString();
}
diff --git a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
index 64f1189..97d9a30 100644
--- a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
+++ b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/internal/IteratorTransformTest.java
@@ -72,17 +72,17 @@ public class IteratorTransformTest {
// filter out odd integers
final int value = input;
if (value % 2 == 0) {
- final char[] chars = (value + "").toCharArray();
+ final char[] chars = (Integer.toString(value)).toCharArray();
if (chars.length > 1) {
final List<String> strs = new ArrayList<>();
for (final char ch : chars) {
- strs.add(ch + "");
+ strs.add(String.valueOf(ch));
}
addAllOutput(strs);
} else if (chars.length == 1) {
- addOutput(chars[0] + "");
+ addOutput(String.valueOf(chars[0]));
}
}
}
diff --git a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
index cf37fa2..35afa7d 100644
--- a/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
+++ b/commons-geometry-core/src/test/java/org/apache/commons/geometry/core/partitioning/bsp/MergeChecker.java
@@ -57,10 +57,10 @@ class MergeChecker {
private int expectedCount = -1;
/** The expected full state of the merged tree */
- private boolean expectedFull = false;
+ private boolean expectedFull;
/** The expected empty state of the merged tree */
- private boolean expectedEmpty = false;
+ private boolean expectedEmpty;
/** Points expected to lie in the inside of the region */
private final List<TestPoint2D> insidePoints = new ArrayList<>();
diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
index 9e265aa..21d69e7 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
@@ -637,7 +637,7 @@ public final class Planes {
private double crossSumZ;
/** If true, an exception will be thrown if the point sequence is discovered to be non-convex. */
- private boolean requireConvex = false;
+ private boolean requireConvex;
/** List that unique vertices discovered in the input sequence will be added to. */
private List<? super Vector3D> uniqueVertexOutput;
diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java
index 3c5b41d..1e70dec 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java
@@ -376,7 +376,7 @@ public final class SimpleTriangleMesh implements TriangleMesh {
private final class FaceIterator<T> implements Iterator<T> {
/** The current index of the iterator. */
- private int index = 0;
+ private int index;
/** Function to apply to each face in the mesh. */
private final Function<? super TriangleMesh.Face, T> fn;
@@ -428,7 +428,7 @@ public final class SimpleTriangleMesh implements TriangleMesh {
private final DoublePrecisionContext precision;
/** Flag set to true once a mesh is constructed from this builder. */
- private boolean built = false;
+ private boolean built;
/** Construct a new builder.
* @param precision precision context used for floating point comparisons; may
diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/path/LinePath.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/path/LinePath.java
index 25a0272..71124eb 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/path/LinePath.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/path/LinePath.java
@@ -458,10 +458,10 @@ public class LinePath implements BoundarySource2D, Sized {
*/
public static final class Builder {
/** Line subsets appended to the path. */
- private List<LineConvexSubset> appended = null;
+ private List<LineConvexSubset> appended;
/** Line subsets prepended to the path. */
- private List<LineConvexSubset> prepended = null;
+ private List<LineConvexSubset> prepended;
/** Precision context used when creating line segments directly from vertices. */
private DoublePrecisionContext precision;
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
index b39dad4..13bd9ee 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/testio/TestOBJWriter.java
@@ -59,7 +59,7 @@ public final class TestOBJWriter implements AutoCloseable {
private DecimalFormat decimalFormat;
/** Number of vertices written to the output. */
- private int vertexCount = 0;
+ private int vertexCount;
/** Create a new instance for writing to the given file.
* @param file file to write to
diff --git a/commons-geometry-hull/src/main/java/org/apache/commons/geometry/hull/euclidean/twod/AbstractConvexHullGenerator2D.java b/commons-geometry-hull/src/main/java/org/apache/commons/geometry/hull/euclidean/twod/AbstractConvexHullGenerator2D.java
index fd5abd3..be9fa95 100644
--- a/commons-geometry-hull/src/main/java/org/apache/commons/geometry/hull/euclidean/twod/AbstractConvexHullGenerator2D.java
+++ b/commons-geometry-hull/src/main/java/org/apache/commons/geometry/hull/euclidean/twod/AbstractConvexHullGenerator2D.java
@@ -68,7 +68,7 @@ abstract class AbstractConvexHullGenerator2D implements ConvexHullGenerator2D {
/** {@inheritDoc} */
@Override
public ConvexHull2D generate(final Collection<Vector2D> points) {
- Collection<Vector2D> hullVertices = null;
+ Collection<Vector2D> hullVertices;
if (points.size() < 2) {
hullVertices = points;
} else {
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
index 269c111..1630827 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Transform1S.java
@@ -182,7 +182,7 @@ public final class Transform1S implements Transform<Point1S> {
.append(isNegation())
.append(", rotate= ")
.append(getRotation())
- .append("]");
+ .append(']');
return sb.toString();
}
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
index 8a82e19..8d449e8 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArc.java
@@ -175,8 +175,7 @@ public final class GreatArc extends GreatCircleSubset implements HyperplaneConve
@Override
public String toString() {
final StringBuilder sb = new StringBuilder();
- sb.append(this.getClass().getSimpleName())
- .append("[");
+ sb.append(this.getClass().getSimpleName()).append('[');
if (isFull()) {
sb.append("full= true, circle= ")
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
index 87631ac..681bc42 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatArcPath.java
@@ -187,7 +187,7 @@ public final class GreatArcPath implements BoundarySource2S {
.append(getVertices());
}
- sb.append("]");
+ sb.append(']');
return sb.toString();
}
@@ -283,10 +283,10 @@ public final class GreatArcPath implements BoundarySource2S {
*/
public static final class Builder {
/** Arcs appended to the path. */
- private List<GreatArc> appendedArcs = null;
+ private List<GreatArc> appendedArcs;
/** Arcs prepended to the path. */
- private List<GreatArc> prependedArcs = null;
+ private List<GreatArc> prependedArcs;
/** Precision context used when creating arcs directly from points. */
private DoublePrecisionContext precision;
diff --git a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
index 8ab514d..024c095 100644
--- a/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
+++ b/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/Transform2S.java
@@ -172,7 +172,7 @@ public final class Transform2S implements Transform<Point2S> {
sb.append(this.getClass().getSimpleName())
.append("[euclideanTransform= ")
.append(getEuclideanTransform())
- .append("]");
+ .append(']');
return sb.toString();
}