You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by vo...@apache.org on 2020/04/18 01:24:01 UTC
[fineract] branch develop updated: Added One Statement per line and
Enforced checkstyle
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new dd2e934 Added One Statement per line and Enforced checkstyle
dd2e934 is described below
commit dd2e934cb12f3d6a2df79f789e01f39e7d728130
Author: thesmallstar <ma...@gmail.com>
AuthorDate: Wed Apr 15 01:37:18 2020 +0530
Added One Statement per line and Enforced checkstyle
---
fineract-provider/config/checkstyle/checkstyle.xml | 3 ++-
.../service/EmailConfigurationWritePlatformServiceImpl.java | 3 ++-
.../fineract/organisation/teller/domain/CashierTxnType.java | 12 ++++++++----
.../useradministration/api/UsersApiResourceSwagger.java | 2 +-
4 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml
index 84195db..e70bca1 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -58,6 +58,7 @@
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="customImportOrderRules" value="STATIC###THIRD_PARTY_PACKAGE"/>
</module>
+ <module name="OneStatementPerLine"/>
<!-- TODO Enable many more checks (go about this one by one, step by step, raise separate PRs fixing and then enforcing):
@@ -130,7 +131,7 @@
value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
</module>
<module name="ParenPad" />
- <module name="OneStatementPerLine"/>
+
<module name="MultipleVariableDeclarations"/>
<module name="ArrayTypeStyle"/>
<module name="MissingSwitchDefault"/>
diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationWritePlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationWritePlatformServiceImpl.java
index 9b110c1..9c517e3 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationWritePlatformServiceImpl.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/service/EmailConfigurationWritePlatformServiceImpl.java
@@ -70,7 +70,8 @@ public class EmailConfigurationWritePlatformServiceImpl implements EmailConfigur
for (EmailConfiguration config : configurations) {
if(config.getName() !=null){
String value = command.stringValueOfParameterNamed(config.getName());
- config.setValue(value); changes.put(config.getName(),value);
+ config.setValue(value);
+ changes.put(config.getName(),value);
this.repository.saveAndFlush(config);
}
}
diff --git a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/CashierTxnType.java b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/CashierTxnType.java
index e307e27..9034432 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/CashierTxnType.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/organisation/teller/domain/CashierTxnType.java
@@ -51,13 +51,17 @@ public class CashierTxnType implements Serializable {
switch(id) {
case 101:
- retVal = ALLOCATE; break;
+ retVal = ALLOCATE;
+ break;
case 102:
- retVal = SETTLE; break;
+ retVal = SETTLE;
+ break;
case 103:
- retVal = INWARD_CASH_TXN; break;
+ retVal = INWARD_CASH_TXN;
+ break;
case 104:
- retVal = OUTWARD_CASH_TXN; break;
+ retVal = OUTWARD_CASH_TXN;
+ break;
default:
break;
}
diff --git a/fineract-provider/src/main/java/org/apache/fineract/useradministration/api/UsersApiResourceSwagger.java b/fineract-provider/src/main/java/org/apache/fineract/useradministration/api/UsersApiResourceSwagger.java
index da15400..5d5a25e 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/useradministration/api/UsersApiResourceSwagger.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/useradministration/api/UsersApiResourceSwagger.java
@@ -81,7 +81,7 @@ final class UsersApiResourceSwagger {
@ApiModelProperty(example = "false")
public Boolean passwordNeverExpires;
public StaffData staff;
- public Collection<RoleData> availableRoles;;
+ public Collection<RoleData> availableRoles;
public Collection<RoleData> selectedRoles;
}