You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/27 06:19:12 UTC

[GitHub] [echarts] MeetzhDing opened a new pull request, #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

MeetzhDing opened a new pull request, #16947:
URL: https://github.com/apache/echarts/pull/16947

   …close #16946
   
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   provide splitLine.showMinLine and splitLine.showMaxLine.
   
   When using xAxis[type=time], it allow user hide first/last splitLine.
   
   
   uplot style: 
   ![uplot styles](https://github.com/leeoniya/uPlot/blob/master/uPlot.png)
   
   ### After: How is it fixed in this PR?
   Like showMinLabel/showMaxLabel, it add new option `showMinLine` adn `showMaxLine`.
   
   
   
   ## Misc
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1309034964

   <img width="1292" alt="image" src="https://user-images.githubusercontent.com/12808432/200888318-7067986f-81cd-4058-a4b8-1ded382d8604.png">
   <img width="1295" alt="image" src="https://user-images.githubusercontent.com/12808432/200888369-9d3703fd-8972-4e70-bc65-0f1eb35db187.png">
   
   @Ovilia please check again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r861441390


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +135,13 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        if (splitLineModel.get('showMinLine') === false) {

Review Comment:
   d



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1138310813

   I have some concern on this PR.
   
   I think it may be a better idea to hide min/max line only if the first/last tick is not calculated by *nice tick* (which usually happens when the user deliberately sets a min/max value to the axis.
   
   For example, in [this demo](https://echarts.apache.org/examples/zh/editor.html?c=line-function&code=GYVwdgxgLglg9mABKSAKAHgSkQbwFCKLqID0AvIgIwAMA3AYgE4CmUIjSAsgIZQAWAOgDOMMBmwAqRD34CIcIRkRSATIgDUVSdN6CRY4lIDMGxCu0BWOngC-eFNHhIA5szDNGvZgBFe3VNj4hAA2rIgAJn6IFADaALr0hMBwjIiooVCIMNGIALQqdFmIADwUBbRF6hTUApSBDISRUNwCAA4gQnyoMTAANMjgEKgwmHGYiYh2hCxsHBF-9HZwrbAIOUGI3GAwALa8TgBcyNzBQsy9DM6MMOFHG4RQy0cALNQXhCHMwFBHVu8f12cfB-iFe_0IACM4FBHjtftQGDZ_ugAILoGBCO4NRBgbg7ZhHADk6EJ4NIJEQO1ER3yb2xQlawRgUAAMqICbhsR9EJ04AB3I5QRggc5cj5M9wAZSgAE9QljuYrEPJgikiSxwoSxYQph9dUiGDK0RiFR9cfiiTKtTr_mdrsxMYgYtj7h9Za0OYSJcxSWLeXzJTKdlDgkdgCczmTCBAma1BcLRUqmtwjq53J4oD4_AFsbq4rZaEA), the min tick is `-20` and it is expected to be displayed because `-20` is a *nice tick*.
   
   <img width="811" alt="image" src="https://user-images.githubusercontent.com/779050/170453541-3e285f15-ea17-41a6-ae2c-f94d5101ff94.png">
   
   
   While in [another case](https://echarts.apache.org/examples/zh/editor.html?c=line-function&code=GYVwdgxgLglg9mABKSAKAHgSkQbwFCKLqID0AvIgIwAMA3AYgE4CmUIjSAsgIZQAWAOgDOMMBmwAqRD34CIcIRkRSATIgDUVSdN6CRY4lIDMGxCu0BWOngC-eFNHhIA5szDNGvZgBFe3VNj4hAA2rIgAJn6IFADaALr0hMBwjIiooVCIMNGIALQqdFmIADwUBbRF6hTUApSBDISRUNwCAA4gQnyoMTAANMjgEKgwmHGYiYh2hCxsHBF-9HZwrbAIOUGI3GAwALa8TgBcyNzBQsy9DM6MMOFHG4RQy0cALNQXhCHMwFBHVu8f12cfB-iFe_0IACM4FBHjtftQGDZ_ugAILoGBCO4NRBgbg7ZhHADk6EJ4MQO1ER3yKjJQlawRgUAAMqICbhsR9EJ04AB3I5QRggc4cj4M9wAZSgAE9QljOfLEPJgikiSxwoSRYQph9tUiGFK0Ri5R9cfiiVKNVr_mdrsxMYgYtj7h9pa02YSxcxSSLuTzxVKdlDgkdgCczmTCBAGa1-YLhQqmtwjq53J4oD4_AFsdq4rZaEA), the axis is set to have `min: -22`. In this case, the splitLine of `-22` is expected to be hidden if `showMinLine` is set to be `false`.
   
   <img width="807" alt="image" src="https://user-images.githubusercontent.com/779050/170453484-0cfa48a0-c702-4284-86d6-68920d296013.png">
   
   
   I think this logic may make more sense. @pissang What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r978241152


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +139,37 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        if (ticksCoords.length > 2 && (axis.scale as any).getInterval instanceof Function) {
+            const interval = (axis.scale as IntervalScale).getInterval() || null;
+            const precision = (axis.scale as IntervalScale).getIntervalPrecision instanceof Function
+                ? (axis.scale as IntervalScale).getIntervalPrecision()
+                : null;
+
+            const showMinLine = splitLineModel.get('showMinLine');
+            if (showMinLine === false
+                || (showMinLine === 'auto'
+                    && roundNumber(

Review Comment:
   Using `roundNumber` to check if it is added as the *nice* extent is not accurate.



##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +139,37 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        if (ticksCoords.length > 2 && (axis.scale as any).getInterval instanceof Function) {

Review Comment:
   Create a new variable for `axis.scale as IntervalScale`



##########
src/coord/axisCommonTypes.ts:
##########
@@ -244,6 +244,10 @@ interface MinorTickOption {
 
 interface SplitLineOption {
     show?: boolean,
+    // null/undefined (true) | true | false | 'auto' (true when nick tick only)
+    showMinLine?: boolean | 'auto',
+    // null/undefined (true) | true | false | 'auto' (true when nick tick only)

Review Comment:
   `null/undefined` is not necessary and they should not have a default value defined here. Instead, the default value should be defined in `axisDefault.ts`.



##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +139,37 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        if (ticksCoords.length > 2 && (axis.scale as any).getInterval instanceof Function) {

Review Comment:
   `instanceof Function` can be omitted. If `getInterval` is not null, we can expect it to be a function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1208915229

   @Ovilia showMinLine type is  ` boolean | 'auto'` now
   ```ts
       // null/undefined (true) | true | false | 'auto' (true when nick tick only)
       showMinLine?: boolean | 'auto',
       // null/undefined (true) | true | false | 'auto' (true when nick tick only)
       showMaxLine?: boolean | 'auto',
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [PR] feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. … [echarts]

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart closed pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …
URL: https://github.com/apache/echarts/pull/16947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1315110588

   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
pissang commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r859465493


##########
src/coord/Axis.ts:
##########
@@ -193,6 +193,13 @@ class Axis {
             this, ticksCoords, alignWithLabel, opt.clamp
         );
 
+        if (tickModel.get('showMinLine') === false) {

Review Comment:
   Modifying the result here will affect the display of labels and ticks lines. If only splitLine will be affected, it's better to do it in the render function https://github.com/apache/echarts/blob/cc0ebd2845781021cb05287fded7c94b26174619/src/component/axis/CartesianAxisView.ts#L141



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [PR] feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. … [echarts]

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-2235418191

   Superseded by #20114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1294643834

   @Ovilia please check pr again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r1022528844


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {

Review Comment:
   Why? For example, when data range is 11~19 and ticksCoords is [10, 20], I believe there should be no split line, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1110633842

   Please don't commit the files in the dist folder


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1263085936

   @Ovilia  please check pr again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r859475767


##########
src/coord/Axis.ts:
##########
@@ -193,6 +193,13 @@ class Axis {
             this, ticksCoords, alignWithLabel, opt.clamp
         );
 
+        if (tickModel.get('showMinLine') === false) {

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
Ovilia commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r1016126877


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {

Review Comment:
   What if `ticksCoords.length` is `2` but the data range is not equal to the ticks' values?



##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {
+            const interval = axisScale.getInterval() || null;
+
+            const showMinLine = splitLineModel.get('showMinLine');
+            if (showMinLine === false
+                || (showMinLine === 'auto'
+                    && ticksCoords[1].tickValue - ticksCoords[0].tickValue < interval

Review Comment:
   Have you tested the case when `axis.inverse` is `true`? `ticksCoords[1].tickValue` may be smaller than `ticksCoords[0].tickValue` in this case.



##########
test/axis-interval.html:
##########
@@ -534,8 +540,68 @@ <h1>Test xAxis.axisTick.interval</h1>
 
 
 
+    <script>
+
+        require([

Review Comment:
   Please add more test cases to test boundary situations. You may start with the cases in my above questions.



##########
test/axis-interval.html:
##########
@@ -534,8 +540,68 @@ <h1>Test xAxis.axisTick.interval</h1>
 
 
 
+    <script>
+
+        require([

Review Comment:
   Please add more test cases to test boundary situations. You may start with the cases in my above questions.



##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {
+            const interval = axisScale.getInterval() || null;

Review Comment:
   What is `|| null` for?



##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {
+            const interval = axisScale.getInterval() || null;
+
+            const showMinLine = splitLineModel.get('showMinLine');
+            if (showMinLine === false

Review Comment:
   `!showMinLine` should be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1196242647

   @MeetzhDing Sorry for the late reply. You can find the code [here](https://github.com/apache/echarts/blob/master/src/scale/Interval.ts#L218-L288).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
pissang commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r861437967


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +135,13 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        if (splitLineModel.get('showMinLine') === false) {

Review Comment:
   We usually use `!splitLineModel.get('showMinLine')` to check false value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1110588132

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on PR #16947:
URL: https://github.com/apache/echarts/pull/16947#issuecomment-1172092269

   @Ovilia @pissang 
   how to judge whether it is `nice tick`?   Or is this any plan yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] MeetzhDing commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

Posted by GitBox <gi...@apache.org>.
MeetzhDing commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r1018148744


##########
src/component/axis/CartesianAxisView.ts:
##########
@@ -135,6 +136,30 @@ const axisElementBuilders: Record<typeof selfBuilderAttrs[number], AxisElementBu
             tickModel: splitLineModel
         });
 
+        const axisScale = axis.scale as IntervalScale;
+        if (ticksCoords.length > 2 && axisScale.getInterval) {

Review Comment:
   When ticksCoords length is 2,  the splitLine is not expected to be hidden



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org