[jira] Resolved: (TRINIDAD-798) StateManagerImpl extends StateManager rather then StateManagerWrapper

["Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TRINIDAD-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott O'Bryan resolved TRINIDAD-798.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.6-core
                   1.0.6-core

In the 1.1 branch, I did some  minor restructuring of the StateManagerImpl to allow for  JSF 1.1 and JSF 1.2 implementations to be somewhat consistent.  Basically I needed to make the original saveSerializedView method private and then implement a new public saveSerializedView method which calls into it.  This was done so that we could change to the new API's in the 1.2 branch while still keeping the same base implementation.

In the 1.2 branch, I took the modifications made to 1.1 and  implemented and extended StateManagerWrapper.  I removed the new saveSerializedView method and implemented a saveView method which calls into the private saveSerializedView method.  When the SerializedView is returned, I create an object array, saving the SerializedView's structure and state in it.  Returning the data in this format allows us to use the same CoreRequestStateManager in both implementations and no other modification is necessary.


> StateManagerImpl extends StateManager rather then StateManagerWrapper
> ---------------------------------------------------------------------
>
>                 Key: TRINIDAD-798
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-798
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Portlet
>    Affects Versions: 1.2.3-core
>         Environment: JSR-168
>            Reporter: Scott O'Bryan
>            Assignee: Scott O'Bryan
>             Fix For: 1.0.6-core, 1.2.6-core
>
>         Attachments: trinidad-798.patch
>
>
> In JSF 1.1, there was no StageManagerWrapper provided by JSF so we were extending the base StateManager.  In 1.2 this class was provided in order to support the delegation chain.  This delegation chain is important to support the JSR-301's portlet bridge.
> Trinidad's StateManagerImpl should be changed to extend JSF1.2's StateManagerWrapper class in order to support this delegation chain.  The mechanism used in 1.1 is not sufficient for 1.2 extensions which may require a StateManager.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.