You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:58:01 UTC

[GitHub] [flink-table-store] zjureel opened a new pull request, #345: [FLINK-29832] Refactor default database name to default_database

zjureel opened a new pull request, #345:
URL: https://github.com/apache/flink-table-store/pull/345

   The `default` is a keyword in SQL and can't be the default database name in table store, the default name will be renamed to `default_database` in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] zjureel commented on pull request #345: [FLINK-29832] Refactor default database name to default_database

Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #345:
URL: https://github.com/apache/flink-table-store/pull/345#issuecomment-1302893696

   Hi @tsreaper I have updated this issue, what do you think of it? THX


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] zjureel closed pull request #345: [FLINK-29832] Refactor default database name to default_database

Posted by GitBox <gi...@apache.org>.
zjureel closed pull request #345: [FLINK-29832] Refactor default database name to default_database
URL: https://github.com/apache/flink-table-store/pull/345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] SteNicholas commented on pull request #345: [FLINK-29832] Refactor default database name to default_database

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #345:
URL: https://github.com/apache/flink-table-store/pull/345#issuecomment-1303208642

   @zjureel, the default database is always `default` in common catalog like `HoodieCatalog`. The users could use the above way to solve the issue you mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] zjureel commented on pull request #345: [FLINK-29832] Refactor default database name to default_database

Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #345:
URL: https://github.com/apache/flink-table-store/pull/345#issuecomment-1303271662

   Thanks @LadyForest @SteNicholas I closed this PR :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] LadyForest commented on pull request #345: [FLINK-29832] Refactor default database name to default_database

Posted by GitBox <gi...@apache.org>.
LadyForest commented on PR #345:
URL: https://github.com/apache/flink-table-store/pull/345#issuecomment-1302911100

   Actually, `default` is a keyword in SQL, and one should escape it when referring it. 
   E.g. 
   ```sql
   SELECT * FROM table_store.`default`.my_table
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org