You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 12:04:14 UTC
[GitHub] [airflow] kaxil opened a new pull request #13612: Change the default celery worker_concurrency to 16
kaxil opened a new pull request #13612:
URL: https://github.com/apache/airflow/pull/13612
I think this change was unintentional -- https://github.com/apache/airflow/pull/7205
That PR just changed it to work with breeze. Since we had `16` as default in 1.10.x
and to get better performance and keep in line with `dag_concurrency` and
`max_active_runs_per_dag` -- I think `16` makes more sense.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13612:
URL: https://github.com/apache/airflow/pull/13612#issuecomment-758141657
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13612:
URL: https://github.com/apache/airflow/pull/13612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13612:
URL: https://github.com/apache/airflow/pull/13612#discussion_r555115582
##########
File path: UPDATING.md
##########
@@ -52,6 +52,13 @@ assists users migrating to a new version.
## Master
+### Default `[celery] worker_concurrency` is changed to `16`
Review comment:
`worker_concurrency` is not the number of workers required -- it is the number of task_instances each Celery Workers will run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13612:
URL: https://github.com/apache/airflow/pull/13612#discussion_r555116793
##########
File path: UPDATING.md
##########
@@ -52,6 +52,13 @@ assists users migrating to a new version.
## Master
+### Default `[celery] worker_concurrency` is changed to `16`
Review comment:
I have pushed 49a71e12b to change the default for tests to 8 -- but I don't see a reason why it should be less than the default in tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13612:
URL: https://github.com/apache/airflow/pull/13612#discussion_r555038693
##########
File path: UPDATING.md
##########
@@ -52,6 +52,13 @@ assists users migrating to a new version.
## Master
+### Default `[celery] worker_concurrency` is changed to `16`
Review comment:
Can we also add env variable to set the ''8" value in `entrypoint_ci,sh` - the number of celery workers also impacts the tests run in GitHub so it would be great to keep the lower value there to keep stability.
##########
File path: UPDATING.md
##########
@@ -52,6 +52,13 @@ assists users migrating to a new version.
## Master
+### Default `[celery] worker_concurrency` is changed to `16`
Review comment:
Can we also add env variable to set the ''8" value in `entrypoint_ci.sh` - the number of celery workers also impacts the tests run in GitHub so it would be great to keep the lower value there to keep stability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13612: Change the default celery worker_concurrency to 16
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13612:
URL: https://github.com/apache/airflow/pull/13612#discussion_r555207271
##########
File path: UPDATING.md
##########
@@ -52,6 +52,13 @@ assists users migrating to a new version.
## Master
+### Default `[celery] worker_concurrency` is changed to `16`
Review comment:
I cannot recall exactly, we can ask @turbaszek, but I believe this was due to stability for some tests in CI that were failing intermittently (likely due to memory issues) when the worker_concurrency was too high and it was easier to change the default value rather than fix the tests (which were simply flaky)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org