You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/12/10 18:37:29 UTC
Review Request 69545: Refactored `LinuxFilesystemIsolator{Test,
MesosTest}` tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69545/
-----------------------------------------------------------
Review request for mesos, Jie Yu and James Peach.
Bugs: MESOS-9462
https://issues.apache.org/jira/browse/MESOS-9462
Repository: mesos
Description
-------
This patch factors out boilerplate code related to initialization of
the agent flags.
Diffs
-----
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
Diff: https://reviews.apache.org/r/69545/diff/1/
Testing
-------
sudo ./src/mesos-tests --gtest_filter=LinuxFilesystemIsolator*
Thanks,
Andrei Budnik
Re: Review Request 69545: Refactored `LinuxFilesystemIsolator{Test,
MesosTest}` tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69545/#review211176
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 10, 2018, 10:37 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69545/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch factors out boilerplate code related to initialization of
> the agent flags.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
>
>
> Diff: https://reviews.apache.org/r/69545/diff/1/
>
>
> Testing
> -------
>
> sudo ./src/mesos-tests --gtest_filter=LinuxFilesystemIsolator*
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69545: Refactored `LinuxFilesystemIsolator{Test,
MesosTest}` tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69545/#review211167
-----------------------------------------------------------
PASS: Mesos patch 69545 was successfully built and tested.
Reviews applied: `['69540', '69545']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2689/mesos-review-69545
- Mesos Reviewbot Windows
On Dec. 10, 2018, 6:37 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69545/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 6:37 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch factors out boilerplate code related to initialization of
> the agent flags.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
>
>
> Diff: https://reviews.apache.org/r/69545/diff/1/
>
>
> Testing
> -------
>
> sudo ./src/mesos-tests --gtest_filter=LinuxFilesystemIsolator*
>
>
> Thanks,
>
> Andrei Budnik
>
>