You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/20 20:53:00 UTC
[jira] [Commented] (BEAM-3219) DataflowRunner: @Setup not called
for batch stateful DoFn
[ https://issues.apache.org/jira/browse/BEAM-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259821#comment-16259821 ]
ASF GitHub Bot commented on BEAM-3219:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/4153
[BEAM-3219] DataflowRunner: delegate @Setup and @Teardown in stateful ParDo
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam batch-stateful-setup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4153
----
commit 44ce37efa39de7dd0a165f2a07a1ec2d1e468c6f
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-11-17T23:17:25Z
DataflowRunner: delegate @Setup and @Teardown in stateful ParDo
----
> DataflowRunner: @Setup not called for batch stateful DoFn
> ---------------------------------------------------------
>
> Key: BEAM-3219
> URL: https://issues.apache.org/jira/browse/BEAM-3219
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.0.0, 2.1.0, 2.2.0
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> Reported on user@beam.apache.org: https://lists.apache.org/thread.html/33c0038508308b69527dab5c3d27cf17ed65fdd9f5d7f6a17cf6d794@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)