You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/13 06:19:51 UTC

[GitHub] [iotdb] Caideyipi commented on a diff in pull request #7576: [IOTDB-4626] Added sql for rpc testing api

Caideyipi commented on code in PR #7576:
URL: https://github.com/apache/iotdb/pull/7576#discussion_r994201449


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/executor/IConfigTaskExecutor.java:
##########
@@ -130,4 +133,12 @@ SettableFuture<ConfigTaskResult> showPathSetTemplate(
 
   SettableFuture<ConfigTaskResult> deleteTimeSeries(
       String queryId, DeleteTimeSeriesStatement deleteTimeSeriesStatement);
+
+  SettableFuture<ConfigTaskResult> getRegion(GetRegionStatement getRegionStatement);

Review Comment:
   After the newest discussion, the new function names regarding getting regions are all renamed, yet the old ones remain the same. Do I have to change them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org