[GitHub] [hudi] danny0405 commented on a diff in pull request #5304: [DOCS] Add faq for async compaction options

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5304:
URL: https://github.com/apache/hudi/pull/5304#discussion_r849028469


##########
website/docs/compaction.md:
##########
@@ -74,7 +74,7 @@ To improve ingestion latency, Async Compaction is the default configuration.
 If immediate read performance of a new commit is important for you, or you want simplicity of not managing separate compaction jobs,
 you may want Synchronous compaction, which means that as a commit is written it is also compacted by the same job.
 
-Compaction is run synchronously by passing the flag "--disable-compaction" (Meaning to disable async compaction scheduling).
+Compaction is run synchronously by passing the flag "--disable-compaction" (Meaning to disable async compaction - disable both scheduling & execution).
 When both ingestion and compaction is running in the same spark context, you can use resource allocation configuration 

Review Comment:
   can we just name the param `--disable-async-compaction` to avoid confusion ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org