You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "microbluey (via GitHub)" <gi...@apache.org> on 2026/08/26 03:47:56 UTC

[PR] [CALCITE-7743] RelJson cannot emit hints [calcite]

microbluey opened a new pull request, #5224:
URL: https://github.com/apache/calcite/pull/5224

   `RelOptUtil.dumpPlan(..., JSON)` throws `UnsupportedOperationException` for any plan whose `LogicalTableScan` carries hints: `LogicalTableScan.explainTerms` emits a `hints` item (added for the CALCITE-4581 digest fix), but `RelJson.toJson(Object)` has no branch for `RelHint`. Reading such a plan back silently dropped the hints.
   
   - `RelJson`: serialize `RelHint` (name, inheritPath, list/kv options, position when not ZERO); `toHint`/`toHints` for reading back
   - `RelInput`: new `getHints()` with an empty default, so existing implementations are unaffected
   - `RelJsonReader` reads the `hints` entry; `TableScan(RelInput)` passes it through, so hints survive the round trip
   
   Only `LogicalTableScan` emits `hints` in explain output today; other `Hintable` nodes put hints in their digest, which does not go through `RelJsonWriter`.
   
   Test: `RelJsonTest.testHint` — SQL with a table hint, dump to JSON (previously threw), read back through `RelJsonReader`, assert hints round-trip.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-7743] RelJson cannot emit hints [calcite]

Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.

mihaibudiu commented on PR #5224:
URL: https://github.com/apache/calcite/pull/5224#issuecomment-5431230324

   Removed the label LGTM to see if checks run. But it seems that checks are still being skipped, although I required all of them to be executed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-7743] RelJson cannot emit hints [calcite]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #5224:
URL: https://github.com/apache/calcite/pull/5224#issuecomment-5420484588

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5224) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5224&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5224&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5224&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [81.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5224&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5224&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5224)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CALCITE-7743] RelJson cannot emit hints [calcite]

Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.

mihaibudiu merged PR #5224:
URL: https://github.com/apache/calcite/pull/5224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org