You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/18 17:39:00 UTC
[jira] [Work logged] (BEAM-5440) Add option to mount a directory
inside SDK harness containers
[ https://issues.apache.org/jira/browse/BEAM-5440?focusedWorklogId=314511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314511 ]
ASF GitHub Bot logged work on BEAM-5440:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 17:38
Start Date: 18/Sep/19 17:38
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8982: [BEAM-5440] Pass docker run options to SDK harness containers
URL: https://github.com/apache/beam/pull/8982#discussion_r300351520
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -128,13 +128,17 @@ def _create_environment(options):
'Unknown environment type: %s' % portable_options.environment_type)
if environment_urn == common_urns.environments.DOCKER.urn:
- docker_image = (
- portable_options.environment_config
- or PortableRunner.default_docker_image())
+ if not portable_options.environment_config:
+ docker_image = PortableRunner.default_docker_image()
+ docker_options = ''
+ else:
+ docker_options, _, docker_image = portable_options.environment_config \
+ .strip().rpartition(' ')
Review comment:
I believe this should decode a JSON config string here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 314511)
Time Spent: 2h 40m (was: 2.5h)
> Add option to mount a directory inside SDK harness containers
> -------------------------------------------------------------
>
> Key: BEAM-5440
> URL: https://issues.apache.org/jira/browse/BEAM-5440
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-core
> Reporter: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> While experimenting with the Python SDK locally, I found it inconvenient that I can't mount a host directory to the Docker containers, i.e. the input must already be in the container and the results of a Write remain inside the container. For local testing, users may want to mount a host directory.
> Since BEAM-5288 the {{Environment}} carries explicit environment information, we could a) add volume args to the {{DockerPayload}}, or b) provide a general Docker arguments field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)