You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/12 04:06:10 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
CalvinKirs opened a new pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027
Reverts apache/incubator-seatunnel#1009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010682122
> Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
Make sense, we can keep it, or we can put a `README.md` in this folder.
> `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
We introduced a `seatunnel-example` module, so this file seems useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010714013
> > > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
> >
> >
> > Make sense, we can keep it, or we can put a `README.md` in this folder.
> > > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
> >
> >
> > We introduced a `seatunnel-example` module, so this file seems useless.
>
> > > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
> >
> >
> > Make sense, we can keep it, or we can put a `README.md` in this folder.
> > > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
> >
> >
> > We introduced a `seatunnel-example` module, so this file seems useless.
>
> I suggest we keep it, it is necessary to keep an example here. This is where users need to care about configuration. If you don't keep it, you also need to submit a `.gitkeep`, we will use this path to parse the user's configuration file.
OK, let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010665266
hi @CalvinKirs, `.gitkeep` and `seatunnel-demo.json` seems useless, we can remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010689019
> > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
>
> Make sense, we can keep it, or we can put a `README.md` in this folder.
>
> > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
>
> We introduced a `seatunnel-example` module, so this file seems useless.
> > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
>
> Make sense, we can keep it, or we can put a `README.md` in this folder.
>
> > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
>
> We introduced a `seatunnel-example` module, so this file seems useless.
I suggest we keep it, it is necessary to keep an example here. This is where users need to care about configuration. If you don't keep it, you also need to submit a `.gitkeep`, we will use this path to parse the user's configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010677856
> hi @CalvinKirs, `.gitkeep` and `seatunnel-demo.json` seems useless, we can remove them?
> hi @CalvinKirs, `.gitkeep` and `seatunnel-demo.json` seems useless, we can remove them?
`.gitkeep` is for placeholders, since we can't commit empty folders.
`seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs edited a comment on pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
CalvinKirs edited a comment on pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010677856
> hi @CalvinKirs, `.gitkeep` and `seatunnel-demo.json` seems useless, we can remove them?
> hi @CalvinKirs, `.gitkeep` and `seatunnel-demo.json` seems useless, we can remove them?
Hi, `.gitkeep` is for placeholders, since we can't commit empty folders.
`seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] nielifeng merged pull request #1027: [SeaTunnel#1023]Revert "[hotfix] remove plugins folder"
Posted by GitBox <gi...@apache.org>.
nielifeng merged pull request #1027:
URL: https://github.com/apache/incubator-seatunnel/pull/1027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org