You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kishan Kavala <Ki...@citrix.com> on 2013/03/19 12:38:17 UTC

Review Request: Corrected RemoveRegion response. Removed /api in Local region end_point

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10009/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

Remove region response corrected to return removeregionresponse instead of updateregionresponse.
Default region should not contain /api in end_point


This addresses bugs CLOUDSTACK-1717 and CLOUDSTACK-1718.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/admin/region/RemoveRegionCmd.java 79c34d0 
  setup/db/db/schema-40to410.sql 865fbd3 

Diff: https://reviews.apache.org/r/10009/diff/


Testing
-------

Tested RemoveRegion API and default region creation.


Thanks,

Kishan Kavala


Re: Review Request: Corrected RemoveRegion response. Removed /api in Local region end_point

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10009/#review18088
-----------------------------------------------------------

Ship it!


Applied to 4.1 branch.  Please update the tickets appropriately.

- Chip Childers


On March 19, 2013, 11:38 a.m., Kishan Kavala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10009/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 11:38 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> Remove region response corrected to return removeregionresponse instead of updateregionresponse.
> Default region should not contain /api in end_point
> 
> 
> This addresses bugs CLOUDSTACK-1717 and CLOUDSTACK-1718.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/region/RemoveRegionCmd.java 79c34d0 
>   setup/db/db/schema-40to410.sql 865fbd3 
> 
> Diff: https://reviews.apache.org/r/10009/diff/
> 
> 
> Testing
> -------
> 
> Tested RemoveRegion API and default region creation.
> 
> 
> Thanks,
> 
> Kishan Kavala
> 
>