You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/28 12:15:11 UTC
[GitHub] [maven] cstamas opened a new pull request, #883: [MNG-6609] Profile activation based on packaging
cstamas opened a new pull request, #883:
URL: https://github.com/apache/maven/pull/883
In short: do NOT set request.setRawModel as NOTHING sets it. The Maven4 vs Maven3 is different, in Maven 3 NOTHING calls request.setRawModel
---
https://issues.apache.org/jira/browse/MNG-6609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1419071474
@delanym you mean the original issue? (as this PR was "just" a fire extinguish/fix for original one). Seems we missed it, @kwin ? Created https://issues.apache.org/jira/browse/MSITE-923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #883: [MNG-6609] Profile activation based on packaging
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #883:
URL: https://github.com/apache/maven/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1331930222
@kwin so does the new IT work? you mentioned something it does not fail with your commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1331933054
I could no longer bring it to fail with my original approach from https://github.com/apache/maven/pull/849 (i.e. it always succeeds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1333554347
IT fixed https://github.com/apache/maven-integration-testing/pull/214#pullrequestreview-1200730814
So am to merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1419229957
Already tracked in https://issues.apache.org/jira/browse/MNGSITE-502, will prepare a PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1329563048
Jut wanted to quickly "publish" my findings about the cause, but around same time moved to something else :smile: feel free to reuse (no need to keep my user ID, after all this is your change set with my one line removal). Or, I can pick it up later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] delanym commented on pull request #883: [MNG-6609] Profile activation based on packaging
Posted by "delanym (via GitHub)" <gi...@apache.org>.
delanym commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1419057631
@cstamas where is this documented? I don't see any change to https://maven.apache.org/guides/introduction/introduction-to-profiles.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org