You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/28 03:30:41 UTC

[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1799: [ISSUE #1798]feat(admin): remove group of deleted sub info when queryTopicConsumeB…

duhenglucky commented on a change in pull request #1799: [ISSUE #1798]feat(admin): remove group of deleted sub info when queryTopicConsumeB…
URL: https://github.com/apache/rocketmq/pull/1799#discussion_r385491861
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -1025,8 +1026,15 @@ private RemotingCommand queryTopicConsumeByWho(ChannelHandlerContext ctx,
             groups.addAll(groupInOffset);
         }
 
+        HashSet<String> filteredGroups = new HashSet<String>();
 
 Review comment:
   It would be better to make an optional configuration here, because some users also want to show the consumption progress of topics that they have subscribed to, and it seems that users in the community are already used to this usage, so forward compatibility is necessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services