Re: Review Request 70763: RANGER-2453: Tag data-masking policy should allow only one tag as resource

[Madhan Neethiraj <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70763/#review215630
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
Lines 592 (patched)
<https://reviews.apache.org/r/70763/#comment302401>

    this 'else' block, which sets 'uiHint' shouldn't be necessary - as the issue reported would be fixed by replacing #574 - #577 (in current version) with a call to getResourceDefForTagResource().
    
    Same for the 'else' block at #617.
    
    To fix already existing resource-def, consider a different approach - like patching service-def.


- Madhan Neethiraj


On May 30, 2019, 11:55 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70763/
> -----------------------------------------------------------
> 
> (Updated May 30, 2019, 11:55 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Nitin Galave, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2453
>     https://issues.apache.org/jira/browse/RANGER-2453
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Tag policy for data masking may be created with multiple values for tag resource using Ranger UI. UI should allow only one value for tag resource, as for tag access policy.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java b0dd283f0 
> 
> 
> Diff: https://reviews.apache.org/r/70763/diff/1/
> 
> 
> Testing
> -------
> 
> Ensured that when creating/updating a tag-based masking policy using UI, only one tag value is allowed as policy-resource.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>