You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pointbreak (JIRA)" <ji...@apache.org> on 2008/10/29 11:25:44 UTC
[jira] Created: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Implement isEscapeLabalMarkup for RadioChoice
---------------------------------------------
Key: WICKET-1900
URL: https://issues.apache.org/jira/browse/WICKET-1900
Project: Wicket
Issue Type: New Feature
Components: wicket
Affects Versions: 1.3.5
Reporter: Pointbreak
The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reopened WICKET-1900:
-----------------------------------
Assignee: (was: Igor Vaynberg)
> Implement isEscapeLabalMarkup for RadioChoice
> ---------------------------------------------
>
> Key: WICKET-1900
> URL: https://issues.apache.org/jira/browse/WICKET-1900
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Pointbreak
> Fix For: 1.3.8
>
>
> The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
> The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
> I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1900:
----------------------------------
Fix Version/s: (was: 1.4-RC2)
(was: 1.3.6)
1.3.8
> Implement isEscapeLabalMarkup for RadioChoice
> ---------------------------------------------
>
> Key: WICKET-1900
> URL: https://issues.apache.org/jira/browse/WICKET-1900
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Pointbreak
> Fix For: 1.3.8
>
>
> The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
> The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
> I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst closed WICKET-1900.
------------------------------------
Resolution: Won't Fix
1.3.8 won't be released.
> Implement isEscapeLabalMarkup for RadioChoice
> ---------------------------------------------
>
> Key: WICKET-1900
> URL: https://issues.apache.org/jira/browse/WICKET-1900
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Pointbreak
>
> The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
> The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
> I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1900.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC2
1.3.6
Assignee: Igor Vaynberg
in 1.3.6 and 1.4 you can do radiochoice.setescapemodelstrings(false) to supress it
same also works for checkboxchoice in 1.4
> Implement isEscapeLabalMarkup for RadioChoice
> ---------------------------------------------
>
> Key: WICKET-1900
> URL: https://issues.apache.org/jira/browse/WICKET-1900
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Pointbreak
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-RC2
>
>
> The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
> The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
> I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1900) Implement isEscapeLabalMarkup for
RadioChoice
Posted by "Alexander Nikiforov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743185#action_12743185 ]
Alexander Nikiforov commented on WICKET-1900:
---------------------------------------------
In my opinion this issue is still open for the releases 1.3.6 and 1.3.7. Although one can call setescapemodelstrings on a radiochoice, this would have no effect on the radiochoice's behavior. This is the code snippet from the release 1.3.7 (and it is identical for 1.3.6)
CharSequence escaped = Strings.escapeMarkup(display, false, true);
buffer.append("<label for=\"").append(idAttr).append("\">").append(escaped).append("</label>");
// Append option suffix
buffer.append(getSuffix());
The label markup is still in any case escaped.
> Implement isEscapeLabalMarkup for RadioChoice
> ---------------------------------------------
>
> Key: WICKET-1900
> URL: https://issues.apache.org/jira/browse/WICKET-1900
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
> Affects Versions: 1.3.5
> Reporter: Pointbreak
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-RC2
>
>
> The CheckBoxMultipleChoice class has a method isEscapeLabelMarkup that can be overriden to suppress escaping the markup of labels for each choice.
> The class RadioChoice is more or less analogous to CheckBoxMultipleChoice, but does not have an isEscapeLabelMarkup method, so no means to suppress escaping the markup of labels.
> I suggest to add this to the interface of RadioChoice as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.