You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:42:13 UTC
[GitHub] [spark] EnricoMi opened a new pull request, #36928: [SPARK-39529][CI] Combine two configure jobs, centralize logic
EnricoMi opened a new pull request, #36928:
URL: https://github.com/apache/spark/pull/36928
### What changes were proposed in this pull request?
CI jobs `configure-jobs` and `precondition` can be combined into a single job, skip logic can be moved into one place.
### Why are the changes needed?
This simplifies the workflow file and puts logic into a single place.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
In CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36928: [SPARK-39529][INFRA] Move skip logic into precondition job
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1161601662
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi closed pull request #36928: [SPARK-39529][INFRA] Move skip logic into precondition job
Posted by GitBox <gi...@apache.org>.
EnricoMi closed pull request #36928: [SPARK-39529][INFRA] Move skip logic into precondition job
URL: https://github.com/apache/spark/pull/36928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36928: [SPARK-39529][CI] Combine two configure jobs, centralize logic
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1160963905
Thanks for taking a look, @EnricoMi . Mind rebasing this please? I think it conflicted with https://github.com/apache/spark/pull/36922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #36928: [SPARK-39529][INFRA] Combine two configure jobs, centralize logic
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1161348791
Not quite, #36922 moves `configure-jobs` together with `on.schedule` and `on.push` out of `build_and_test.yml` while this PR combines `preconditions` with `configure-jobs` and moves logic from across the workflow into `configure-jobs". So that can still be done, but now moving it into `preconditions`.
I can rebase this and move the logic into `preconditions`. Are there any other reworks going on right now? Visibility of concurrent work is poor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #36928: [SPARK-39529][INFRA] Combine two configure jobs, centralize logic
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1161405527
@HyukjinKwon rebased. The conflicts weren't too bad, and the diff looks still useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36928: [SPARK-39529][INFRA] Move skip logic into precondition job
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1161613493
The approach seems pretty fine to put the logics into precondition. I have another idea on the top of this PR. Let me create a PR - let's co-author my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #36928: [SPARK-39529][CI] Combine two configure jobs, centralize logic
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1160466102
@HyukjinKwon here is some simplification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] EnricoMi commented on pull request #36928: [SPARK-39529][INFRA] Move skip logic into precondition job
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1163168579
Fixed by #36940.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36928: [SPARK-39529][INFRA] Combine two configure jobs, centralize logic
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36928:
URL: https://github.com/apache/spark/pull/36928#issuecomment-1160964597
and .. seems like actually what this PR does is similar with https://github.com/apache/spark/pull/36922 in fact :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org