You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/05 23:52:39 UTC
[jira] [Commented] (SOLR-8612) DIH JdbcDataSource - statement not
always closed
[ https://issues.apache.org/jira/browse/SOLR-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135194#comment-15135194 ]
ASF GitHub Bot commented on SOLR-8612:
--------------------------------------
GitHub user tinexw opened a pull request:
https://github.com/apache/lucene-solr/pull/6
[SOLR-8612] DIH JdbcDataSource: Always close ResultSet and Statement
and also some more minor changes for better extensibility (https://issues.apache.org/jira/browse/SOLR-8618)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinexw/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 77d86ef11a1898109c0abf41a8123052d41ae69f
Author: tinexw <kr...@kreuzwerker.de>
Date: 2016-02-05T22:42:18Z
Always close ResultSet and Statement and also some more changes for
better extensibility
----
> DIH JdbcDataSource - statement not always closed
> ------------------------------------------------
>
> Key: SOLR-8612
> URL: https://issues.apache.org/jira/browse/SOLR-8612
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 5.4.1
> Reporter: Kristine Jetzke
> Fix For: Trunk
>
> Attachments: SOLR-8612.patch, SOLR-8612.patch, SOLR-8612.patch, SOLR-8612.patch
>
>
> There are several cases where the Statement used by JdbcDataSource is not closed, potentially resulting in too many open connections:
> - an exception is throw in the {{ResultSetIterator}} constructor
> - the result set is null in the {{ResultSetIterator}} constructor
> - an exception is thrown during import and the import is aborted (onError flag set to abort)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org