You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "anishgirianish (via GitHub)" <gi...@apache.org> on 2025/12/28 01:36:28 UTC
[PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
anishgirianish opened a new pull request, #59862:
URL: https://github.com/apache/airflow/pull/59862
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #59229
related: #59229
Integrates OpenAPI Generator version updates into the existing Breeze CI upgrade flow, addressing the maintenance gap described in #59229. This ensures the pinned generator version is kept up to date when running standard upgrade tooling, without changing generated clients or runtime behavior.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "anishgirianish (via GitHub)" <gi...@apache.org>.
anishgirianish commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649841231
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -408,6 +421,7 @@ def get_env_bool(name: str, default: bool = True) -> bool:
UPGRADE_UV: bool = get_env_bool("UPGRADE_UV")
UPGRADE_MYPY: bool = get_env_bool("UPGRADE_MYPY")
UPGRADE_PROTOC: bool = get_env_bool("UPGRADE_PROTOC")
+UPGRADE_OPENAPI_GENERATOR: bool = get_env_bool("UPGRADE_OPENAPI_GENERATOR")
Review Comment:
Thank you for pointing this out. I’ve updated the PR to include the necessary changes to the CI workflows as well, so this should now be safe to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649886935
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
(and only leave "false" one in the following job ? - this way whenever we add something - it only has to be added in one of those jobs.
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
(and only leave "false" one in the following job ? - this way whenever we add something - it only has to be added in one of those steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #59862:
URL: https://github.com/apache/airflow/pull/59862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649885771
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
Actually .... UPGRADE_PROTC and UPGRADE_OPENAPI_GENERATOR here should be "true" :) - which means that we should try to upgrade it, but it should not fail the build) - this way we can immediately see which packages are not upgraded yet by looking at teh last "canary" build's output of this step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #59862:
URL: https://github.com/apache/airflow/pull/59862#issuecomment-3694360746
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59862:
URL: https://github.com/apache/airflow/pull/59862#issuecomment-3697385281
Backport in https://github.com/apache/airflow/pull/59910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59862:
URL: https://github.com/apache/airflow/pull/59862#issuecomment-3696004704
### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/20569804531'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/commit/c273d8d1426d9fdf79e23fdded24fc7834722863"><img src='https://img.shields.io/badge/Commit-c273d8d-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker c273d8d v3-1-test
```
This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #59862:
URL: https://github.com/apache/airflow/pull/59862#issuecomment-3696000676
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59862:
URL: https://github.com/apache/airflow/pull/59862#issuecomment-3694601071
Can you please also add it to the CI workflows (there are two steps that need to be updated) https://github.com/apache/airflow/blob/main/.github/workflows/basic-tests.yml#L297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "anishgirianish (via GitHub)" <gi...@apache.org>.
anishgirianish commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649898426
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
Thank you very much for the guidance. I’ve updated the upgrade-check steps to keep only the "false" values in the informational step and skip non-critical upgrades in the failing step. Appreciate your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649886935
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
(and only leave "false" one in the following job ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649584625
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -408,6 +421,7 @@ def get_env_bool(name: str, default: bool = True) -> bool:
UPGRADE_UV: bool = get_env_bool("UPGRADE_UV")
UPGRADE_MYPY: bool = get_env_bool("UPGRADE_MYPY")
UPGRADE_PROTOC: bool = get_env_bool("UPGRADE_PROTOC")
+UPGRADE_OPENAPI_GENERATOR: bool = get_env_bool("UPGRADE_OPENAPI_GENERATOR")
Review Comment:
This needs to be added to the CI workflows too. Adding comment so that it's not merged automatically,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649584625
##########
scripts/ci/prek/upgrade_important_versions.py:
##########
@@ -408,6 +421,7 @@ def get_env_bool(name: str, default: bool = True) -> bool:
UPGRADE_UV: bool = get_env_bool("UPGRADE_UV")
UPGRADE_MYPY: bool = get_env_bool("UPGRADE_MYPY")
UPGRADE_PROTOC: bool = get_env_bool("UPGRADE_PROTOC")
+UPGRADE_OPENAPI_GENERATOR: bool = get_env_bool("UPGRADE_OPENAPI_GENERATOR")
Review Comment:
This needs to be added to the CI workflows too. Adding comment so that it's not merged accidentally,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Breeze: keep OpenAPI Generator version in sync during CI upgrades [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #59862:
URL: https://github.com/apache/airflow/pull/59862#discussion_r2649886554
##########
.github/workflows/basic-tests.yml:
##########
@@ -315,6 +315,7 @@ jobs:
UPGRADE_MPROCS: "true"
UPGRADE_MYPY: "false"
UPGRADE_PROTOC: "false"
+ UPGRADE_OPENAPI_GENERATOR: "false"
Review Comment:
Or ... actually, since UPGRADE_* default is "true" - maybe we should remove all those variables that have "true" value here - this will be a bit less confusing what's going on here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org