You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2025/12/19 02:34:04 UTC
[PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
mihaibudiu opened a new pull request, #4696:
URL: https://github.com/apache/calcite/pull/4696
I fixed most classes, but I don't know how to fix the SqlAttributeDefinition fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3688090662
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [69.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_coverage&view=list)
 [2.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3676220247
So @dssysolyatin your recommendation is to switch to use SqlOperator everywhere?
What other changes are necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2642207496
##########
core/src/main/java/org/apache/calcite/sql/ddl/SqlCreateFunction.java:
##########
@@ -91,6 +104,9 @@ private List<Pair<SqlLiteral, SqlLiteral>> pairs() {
}
@Override public List<SqlNode> getOperandList() {
- return Arrays.asList(name, className, usingList);
+ return Arrays.asList(
Review Comment:
Can we use `ImmutableList` as in another places ?
##########
core/src/main/java/org/apache/calcite/sql/SqlCollation.java:
##########
@@ -113,6 +115,31 @@ public SqlCollation(
this.collationName = generateCollationName(charset);
}
+ /** Encode all the information require to reconstruct a SqlCollection in a SqlList object. */
+ public SqlNodeList asList() {
Review Comment:
Why we can not just use string generated by`SqlCollation.generateCollationName` ? and construct SqlCollation using
```
@JsonCreator
public SqlCollation(
@JsonProperty("collationName") String collation,
@JsonProperty("coercibility") Coercibility coercibility) {
```
##########
core/src/main/java/org/apache/calcite/sql/SqlLambda.java:
##########
@@ -107,6 +107,13 @@ private static class SqlLambdaOperator extends SqlSpecialOperator {
super("->", SqlKind.LAMBDA);
}
+ @Override public SqlCall createCall(
Review Comment:
Do you need lambda in this PR ?
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7339">[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
Does this test tests everything ?
Can we just add common test https://github.com/apache/calcite/pull/4644/files#diff-766dbf236baaf33399a8d3620404b261faa80c27dadb95379e0747f915380e44 but have boolean flag which enable it only for `ServerUnParserTest` ?
##########
core/src/main/java/org/apache/calcite/sql/SqlCollation.java:
##########
@@ -113,6 +115,31 @@ public SqlCollation(
this.collationName = generateCollationName(charset);
}
+ /** Encode all the information require to reconstruct a SqlCollection in a SqlList object. */
+ public SqlNodeList asList() {
+ return new SqlNodeList(
+ ImmutableNullableList.of(
+ SqlLiteral.createCharString(coercibility.name(), SqlParserPos.ZERO),
Review Comment:
Can we use SqlLiteral.createSymbol as it works with enums ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3676193805
I tried to use these classes and I couldn't.
I think we can use any operator as long as we override the method to create a call.
I am not sure it's enough to have collation extend SqlNode; wouldn't some visitors need to know about it too?
I see that Collation in attributes is never set, but maybe it's used in derived classes.
One can convert enums to SqlLiterals with string values. But how about the Locale in the Collation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3684675513
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [32.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_coverage&view=list)
 [2.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2642219431
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7339">[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
Does this test tests everything ?
Can we just add common test [SqlParserTest.java](https://github.com/apache/calcite/pull/4644/files#diff-766dbf236baaf33399a8d3620404b261faa80c27dadb95379e0747f915380e44) but have boolean flag which enable it only for `ServerUnParserTest` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #4696:
URL: https://github.com/apache/calcite/pull/4696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2643926943
##########
core/src/main/java/org/apache/calcite/sql/SqlLambda.java:
##########
@@ -107,6 +107,13 @@ private static class SqlLambdaOperator extends SqlSpecialOperator {
super("->", SqlKind.LAMBDA);
}
+ @Override public SqlCall createCall(
Review Comment:
It is the same kind of problem, although the class is not in DDL.
We will have to fix it at some point, so why not now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3688043512
@dssysolyatin I hope I have made the changes you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3675503103
I don't understand this place very well. It would be great if @dssysolyatin could help to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3684431693
Indeed, I forgot about #4644; this is a subset of the work in #4644, and has nothing to do with unparse. You can think of this as half of #4644. We run into problems with visitors for these classes, so I would like to solve this before #4644 is finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3675642290
@mihaibudiu You decided not to wait for the PR and did the work yourself: https://github.com/apache/calcite/pull/4644. That’s totally understandable. I’m sorry I couldn’t finish my PR in time, so I understand why you moved forward.
If possible, please use SqlBasicOperator. See the discussion here:
https://issues.apache.org/jira/browse/CALCITE-5403 (especially this [comment](https://issues.apache.org/jira/browse/CALCITE-5403?focusedCommentId=17710252&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17710252
))
> Having a subclass of SqlSpecialOperator for every kind of Ast node is a pattern that we need to stop doing. Can you find a way to do this using SqlBasicOperator or similar?
If method is private:
```
private static final SqlSpecialOperator OPERATOR
```
we can change `SqlSpecialOperator` to `SqlOperator`
```
private static final SqlOperator OPERATOR
```
and use SqlBasicOperator instead. See example inside https://github.com/apache/calcite/pull/4644
Regarding SqlAttributeDefinition:
1. I don’t see where `SqlCollation` is used for `SqlAttributeDefinition`. In the parser, [the only place](https://github.com/apache/calcite/blob/23b7931c3e516bdb6cfedda956213f7fe06c6b24/server/src/main/codegen/includes/parserImpls.ftl#L219) that references it passes null for `SqlAttributeDefinition`. So, I assume nobody uses it.
2. If we decide to support it later, I think SqlCollation should extend SqlNode directly. It already has an unparse method. For Coercibility, you can use SqlLiteral.createSymbol().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2644751243
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7339">[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
This is one way to check that all operators have createCall and that it creates SqlCall correctly.
1. Parse the SQL string into a SqlNode.
2. Unparse it and save the result as sql1.
3. Parse the SQL again.
4. Apply a shuttle that makes a deep copy of the tree.
5. Unparse it again and check that the SQL string is the same as in step 2.
This way, we do not need to write a separate test for each SqlOperator. Having separate tests is also good, but with separate tests we might forget to write one and miss validating some cases.
Anyway, you can just skip this part as separate tests are also OK for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3688635094
I see your point, that would have been simpler, but since I did it, I will probably leave it like this. At least it's obvious what is being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3677903533
The main recommendation is to use `SqlBasicOperator` instead of making new subclasses of `SqlSpecialOperator`. Example https://github.com/apache/calcite/pull/4644/files#diff-0e0b4e3b10ec6fc8fcd1910b4d2b070e0c0b5a62d5bd75befbd46d3d7d33712c
```java
private static final SqlOperator OPERATOR =
SqlBasicOperator.create("ATTRIBUTE_DEF", SqlKind.ATTRIBUTE_DEF)
.withCallFactory((operator, functionQualifier, pos, operands) ->
new SqlAttributeDefinition(
pos,
(SqlIdentifier) requireNonNull(operands[0]),
(SqlDataTypeSpec) requireNonNull(operands[1]),
operands[2], null));
```
> I tried to use these classes and I couldn't.
Do you mean you tried `SqlBasicOperator` and it didn’t work as expected?
> to switch to use SqlOperator everywhere?
In current cases, all `OPERATOR`s are private (For public properties, it would be better to use just `SqlOperator` to avoid possible compatibility issues in the future). Therefore, if SqlBasicOperator is not used, there is no real need to change this.
> One can convert enums to SqlLiterals with string values. But how about the Locale in the Collation?
Is a simple string insufficient to represent a Locale and Collation? I think it want one of the constructor does:
```java
public SqlCollation(
@JsonProperty("collationName") String collation,
@JsonProperty("coercibility") Coercibility coercibility) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2644112970
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7339">[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
I don't think that my changes affect parsing and unparsing, they affect for sure visitors that mutate these classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "dssysolyatin (via GitHub)" <gi...@apache.org>.
dssysolyatin commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2644751243
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7339">[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
This is one way to check that all operators have createCall and that it creates SqlCall correctly.
1. Parse the SQL string into a SqlNode.
2. Unparse it and save the result as sql1.
3. Parse the SQL again.
4. Apply a shuttle that makes a deep copy of the tree.
5. Unparse copied tree and check that the SQL string is the same as in step 2.
This way, we do not need to write a separate test for each SqlOperator. Having separate tests is also good, but with separate tests we might forget to write one and miss validating some cases.
Anyway, you can just skip this part as separate tests are also OK for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3673287553
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [21.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_coverage&view=list)
 [2.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3684715853
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [33.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_coverage&view=list)
 [2.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3684576908
@dssysolyatin turns out that if you switch from SqlSpecialOperator to SqlBasicOperators quite a few tests start failing, I didn't investigate why. But your PR may have the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7339] Most classes in SqlDdlNodes use an incorrect SqlCallFactory [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4696:
URL: https://github.com/apache/calcite/pull/4696#issuecomment-3688662273
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4696&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4696&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [69.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_coverage&view=list)
 [2.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4696&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4696)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org