You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Siveton <vi...@gmail.com> on 2005/08/06 16:42:10 UTC

RE: svn commit: r230549 - in /maven/components/trunk/maven-plugins/maven-javadoc-plugin: ./ src/main/java/org/apache/maven/plugin/javadoc/ src/test/projects/javadoc-plugin-test1/ src/test/projects/javadoc-plugin-test1/src/main/java/org/apache/maven/plugin

Hi,

[SNIP]

> 
> Why did you add plexus-utils as a dependency?

Brett tells me to do that.

"it is better to be explicit if you actually depend on it to avoid the side
effect of it being removed from a transitive dep and inadvertently breaking
your build."

Cheers,

Vincent



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: svn commit: r230549 - in /maven/components/trunk/maven-plugins/maven-javadoc-plugin: ./ src/main/java/org/apache/maven/plugin/javadoc/ src/test/projects/javadoc-plugin-test1/ src/test/projects/javadoc-plugin-test1/src/main/java/org/apache/maven/plugin

Posted by Vincent Siveton <vi...@gmail.com>.
Hi again,

[SNIP]

> Ok, that's right. Could you please make sure to include a more explicit
> reason when doing this in the future?
> 
> Including the reasons why you're changing a dependency, eg: adding,
> removing or changing the scope/version is important as it might have a
> impact on projects depending on the current project.

I will try to be clearer on comments, especially on dependencies.
Thanks!

Cheers,

Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r230549 - in /maven/components/trunk/maven-plugins/maven-javadoc-plugin: ./ src/main/java/org/apache/maven/plugin/javadoc/ src/test/projects/javadoc-plugin-test1/ src/test/projects/javadoc-plugin-test1/src/main/java/org/apache/maven/plugin

Posted by Trygve Laugstøl <tr...@codehaus.org>.
On Sat, Aug 06, 2005 at 10:42:10AM -0400, Vincent Siveton wrote:
> Hi,
> 
> [SNIP]
> 
> > 
> > Why did you add plexus-utils as a dependency?
> 
> Brett tells me to do that.
> 
> "it is better to be explicit if you actually depend on it to avoid the side
> effect of it being removed from a transitive dep and inadvertently breaking
> your build."

Ok, that's right. Could you please make sure to include a more explicit
reason when doing this in the future?

Including the reasons why you're changing a dependency, eg: adding,
removing or changing the scope/version is important as it might have a
impact on projects depending on the current project.

--
Trygve