You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/06 09:01:22 UTC

[GitHub] [pulsar] momo-jun opened a new pull request, #15469: [improve][doc] Clarify the definition of message key

momo-jun opened a new pull request, #15469:
URL: https://github.com/apache/pulsar/pull/15469

   
   Fixes  #15380.
   
   ### Modifications
   
   Add information to link with partition key and show its data type.
   
   The preview looks good.
   
   <img width="1425" alt="image" src="https://user-images.githubusercontent.com/60642177/167100720-d8e89e4d-76ce-40e5-a34d-bef1b47abb6f.png">
   
   
   ### Documentation
     
   - [ ] `doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #15469: [improve][doc] Clarify the definition of message key

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15469:
URL: https://github.com/apache/pulsar/pull/15469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15469: [improve][doc] Clarify the definition of message key

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15469:
URL: https://github.com/apache/pulsar/pull/15469#issuecomment-1119407153

   @momo-jun:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15469: [improve][doc] Clarify the definition of message key

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15469:
URL: https://github.com/apache/pulsar/pull/15469#issuecomment-1119405241

   @momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on pull request #15469: [improve][doc] Clarify the definition of message key

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15469:
URL: https://github.com/apache/pulsar/pull/15469#issuecomment-1119407435

   @RobertIndie @codelipenghui can you pls review this doc PR? Thanks.
   //cc @Anonymitaet 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org