You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/18 09:50:27 UTC

[GitHub] [iotdb] 23931017wu opened a new pull request, #7041: [IOTDB-4136] [sync] Sync sender-side statement generation

23931017wu opened a new pull request, #7041:
URL: https://github.com/apache/iotdb/pull/7041

   ## Resolve SQL to statement
   
   ShowPipeSinkStatment
   ShowPipeSinkTypeStatement
   ShowPipeStatament
   OperatePipeSinkStatement
   OperatePipeStatement
    
   ### Solve the misjudgment of "time" in SQL
   #### Before
   ![图片](https://user-images.githubusercontent.com/71131924/185366279-f20221da-40f9-4ffb-8d9f-568d9abb3a51.png)
   
   #### After
   ![图片](https://user-images.githubusercontent.com/71131924/185366197-d66209c6-7381-404f-9af7-422c6fe13d50.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #7041: [IOTDB-4136] [sync] Sync sender-side statement generation

Posted by GitBox <gi...@apache.org>.
Cpaulyz commented on code in PR #7041:
URL: https://github.com/apache/iotdb/pull/7041#discussion_r949904628


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/statement/sys/OperatePipeSinkStatement.java:
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.statement.sys;
+
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.db.mpp.plan.analyze.QueryType;
+import org.apache.iotdb.db.mpp.plan.constant.StatementType;
+import org.apache.iotdb.db.mpp.plan.statement.IConfigStatement;
+import org.apache.iotdb.db.mpp.plan.statement.Statement;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+public class OperatePipeSinkStatement extends Statement implements IConfigStatement {

Review Comment:
   Split into CreatePipeSinkStatement, DropPipeSinkStatement



##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/statement/sys/OperatePipeStatement.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.statement.sys;
+
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.db.mpp.plan.analyze.QueryType;
+import org.apache.iotdb.db.mpp.plan.constant.StatementType;
+import org.apache.iotdb.db.mpp.plan.statement.IConfigStatement;
+import org.apache.iotdb.db.mpp.plan.statement.Statement;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+public class OperatePipeStatement extends Statement implements IConfigStatement {

Review Comment:
   Split into CreatePipeStatement, StopPipeStatement, StartPipeStatement, DropPipeStatement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] 23931017wu closed pull request #7041: [IOTDB-4136] [sync] Sync sender-side statement generation

Posted by GitBox <gi...@apache.org>.
23931017wu closed pull request #7041: [IOTDB-4136] [sync] Sync sender-side statement generation
URL: https://github.com/apache/iotdb/pull/7041


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] 23931017wu commented on a diff in pull request #7041: [IOTDB-4136] [sync] Sync sender-side statement generation

Posted by GitBox <gi...@apache.org>.
23931017wu commented on code in PR #7041:
URL: https://github.com/apache/iotdb/pull/7041#discussion_r950016333


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/statement/sys/OperatePipeSinkStatement.java:
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.statement.sys;
+
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.db.mpp.plan.analyze.QueryType;
+import org.apache.iotdb.db.mpp.plan.constant.StatementType;
+import org.apache.iotdb.db.mpp.plan.statement.IConfigStatement;
+import org.apache.iotdb.db.mpp.plan.statement.Statement;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+public class OperatePipeSinkStatement extends Statement implements IConfigStatement {

Review Comment:
   OK ~
   



##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/statement/sys/OperatePipeStatement.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.statement.sys;
+
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.db.mpp.plan.analyze.QueryType;
+import org.apache.iotdb.db.mpp.plan.constant.StatementType;
+import org.apache.iotdb.db.mpp.plan.statement.IConfigStatement;
+import org.apache.iotdb.db.mpp.plan.statement.Statement;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+public class OperatePipeStatement extends Statement implements IConfigStatement {

Review Comment:
   OK ~
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #7041: [IOTDB-4136] [sync] Sync sender-side statement generation

Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #7041:
URL: https://github.com/apache/iotdb/pull/7041


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org