[GitHub] [superset] etr2460 commented on a change in pull request #16683: feat: add global max row limit

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #16683:
URL: https://github.com/apache/superset/pull/16683#discussion_r709370893



##########
File path: superset/utils/core.py
##########
@@ -1762,3 +1762,29 @@ def parse_boolean_string(bool_str: Optional[str]) -> bool:
         return bool(strtobool(bool_str.lower()))
     except ValueError:
         return False
+
+
+def apply_max_row_limit(max_limit: Optional[int], limit: int) -> int:

Review comment:
       instead of needing to pass in the max row limit, should we access the config value here? Seems like the first argument is always set to the same thing where this function is used




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org