You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/23 13:51:43 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7175: libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
anchao opened a new pull request, #7175:
URL: https://github.com/apache/incubator-nuttx/pull/7175
## Summary
libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
armclang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7175: libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7175:
URL: https://github.com/apache/incubator-nuttx/pull/7175#issuecomment-1256403276
Since this change simply remove built-in functions implemented on ARM, Let's ignore macOS false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7175: libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7175:
URL: https://github.com/apache/incubator-nuttx/pull/7175#issuecomment-1256380027
> @xiaoxiang781216 do you recall why it was originally added?
Sorry, I can't remember why add these functions:(. But since these functions block armclang LTO link, we can remove these functions first, and watch any bad feedback. Anyway, it's always be good to prefer the implementation provided by compiler.
> Was it because we used no-builtin flag?
https://github.com/apache/incubator-nuttx/pull/5971 is related to no-builtin, not __aeabi_memxxx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7175: libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7175:
URL: https://github.com/apache/incubator-nuttx/pull/7175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7175: libs/libc/arm: use builtin routines instead of aliases of __aeabi_mem*
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7175:
URL: https://github.com/apache/incubator-nuttx/pull/7175#issuecomment-1256334324
@xiaoxiang781216 do you recall why it was originally added? Was it because we used no-builtin flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org