You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2021/02/09 17:14:28 UTC

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17050


Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................

IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Eliminated some of the noisy per-instance counters
from DEFAULT verbosity.

Testing:
* Updated impala-profile-tool test with new output
* Added new impala-profile-tool test for v2 profile.

Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/README
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
M tests/observability/test_profile_tool.py
7 files changed, 5,755 insertions(+), 516 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/17050/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6884/


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 06:50:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/8106/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Feb 2021 17:34:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 1: Code-Review+2

I think this makes sense as a way to cut down the verbosity for the DEFAULT level.

The flake8 line length issues don't bother me that much given that it is driven by long filenames, but if there is an easy fix, go for it.


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Feb 2021 23:29:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4:

Hit IMPALA-10501


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 17:50:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 23:34:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py
File tests/observability/test_profile_tool.py:

http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py@50
PS1, Line 50: )
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py@53
PS1, Line 53: )
flake8: E501 line too long (92 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Feb 2021 17:15:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py
File tests/observability/test_profile_tool.py:

http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py@50
PS1, Line 50: )
> flake8: E501 line too long (91 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/17050/1/tests/observability/test_profile_tool.py@53
PS1, Line 53: )
> flake8: E501 line too long (92 > 90 characters)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:02:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:02:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17050

to look at the new patch set (#4).

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................

IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Eliminated some of the noisy per-instance counters
from DEFAULT verbosity.

Testing:
* Updated impala-profile-tool test with new output
* Added new impala-profile-tool test for v2 profile.

Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
---
M be/src/util/runtime-profile.cc
M bin/rat_exclude_files.txt
M testdata/impala-profiles/README
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
M tests/observability/test_profile_tool.py
8 files changed, 5,760 insertions(+), 516 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/17050/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6885/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 17:50:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6883/


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:24:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/8122/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:22:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4: Code-Review+2

fix rat exclusdes


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:24:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6883/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:02:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 2: Code-Review+2

carry


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:02:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8124/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:37:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................

IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Eliminated some of the noisy per-instance counters
from DEFAULT verbosity.

Testing:
* Updated impala-profile-tool test with new output
* Added new impala-profile-tool test for v2 profile.

Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Reviewed-on: http://gerrit.cloudera.org:8080/17050
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/runtime-profile.cc
M bin/rat_exclude_files.txt
M testdata/impala-profiles/README
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
M tests/observability/test_profile_tool.py
8 files changed, 5,760 insertions(+), 516 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17050

to look at the new patch set (#2).

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................

IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Eliminated some of the noisy per-instance counters
from DEFAULT verbosity.

Testing:
* Updated impala-profile-tool test with new output
* Added new impala-profile-tool test for v2 profile.

Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
---
M be/src/util/runtime-profile.cc
M testdata/impala-profiles/README
M testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_default.expected.txt
A testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_v2_extended.expected.txt
M tests/observability/test_profile_tool.py
7 files changed, 5,757 insertions(+), 516 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/17050/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9382: part 3/3 clean up runtime profile v2 text output

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17050 )

Change subject: IMPALA-9382: part 3/3 clean up runtime profile v2 text output
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6884/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Gerrit-Change-Number: 17050
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Feb 2021 01:24:31 +0000
Gerrit-HasComments: No