You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/08/23 13:51:59 UTC

Review Request 51332: LENS-1283: throw LensAPIException in lens client code when http status is 500 and APIResult payload is provided with FAILED status

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 6ce8209eec3a8a92c14462f82e7c3ec5921d855a 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSegmentationCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensSegmentationCommands.java e53442d2e169c003326eff0d83a826bb22aa7c37 
  lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml bfcf16b997fc101e7d2904b9e5ebed5d1bdd480c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.

> On Sept. 15, 2016, 2:43 p.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java, line 63
> > <https://reviews.apache.org/r/51332/diff/11/?file=1491554#file1491554line63>
> >
> >     whats the plan for these disabled tests?

These can be removed. But just in case, if in future some other changes are done in the code, then some of these tests might become relevant. Hence, I didn't remove, only disabled.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/#review149036
-----------------------------------------------------------


On Sept. 6, 2016, 2:48 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51332/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 2:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1283
>     https://issues.apache.org/jira/browse/LENS-1283
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
>   lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
>   lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
>   lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java c536ed649b6a54d008c20040aba6f98ee009b7b9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
>   lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
>   lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
>   lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
>   lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 
> 
> Diff: https://reviews.apache.org/r/51332/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/#review149036
-----------------------------------------------------------


Fix it, then Ship it!





lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java (line 63)
<https://reviews.apache.org/r/51332/#comment216574>

    whats the plan for these disabled tests?


- Amareshwari Sriramadasu


On Sept. 6, 2016, 9:18 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51332/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 9:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1283
>     https://issues.apache.org/jira/browse/LENS-1283
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
>   lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
>   lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
>   lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java c536ed649b6a54d008c20040aba6f98ee009b7b9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
>   lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
>   lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
>   lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
>   lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 
> 
> Diff: https://reviews.apache.org/r/51332/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 2:48 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java c536ed649b6a54d008c20040aba6f98ee009b7b9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 30, 2016, 4:52 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java c536ed649b6a54d008c20040aba6f98ee009b7b9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 29, 2016, 3:34 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 1:13 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 25, 2016, 1:07 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 
  lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 5:13 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 1:40 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: Map failure APIResult to Exception in Lens client

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 1:36 p.m.)


Review request for lens.


Summary (updated)
-----------------

LENS-1283: Map failure APIResult to Exception in Lens client


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSegmentationCommands.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: throw LensAPIException in lens client code when http status is 500 and APIResult payload is provided with FAILED status

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 1:29 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 6ce8209eec3a8a92c14462f82e7c3ec5921d855a 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSegmentationCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensSegmentationCommands.java e53442d2e169c003326eff0d83a826bb22aa7c37 
  lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml bfcf16b997fc101e7d2904b9e5ebed5d1bdd480c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51332: LENS-1283: throw LensAPIException in lens client code when http status is 500 and APIResult payload is provided with FAILED status

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51332/
-----------------------------------------------------------

(Updated Aug. 23, 2016, 7:46 p.m.)


Review request for lens.


Bugs: LENS-1283
    https://issues.apache.org/jira/browse/LENS-1283


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 6ce8209eec3a8a92c14462f82e7c3ec5921d855a 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSegmentationCommands.java PRE-CREATION 
  lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensSegmentationCommands.java e53442d2e169c003326eff0d83a826bb22aa7c37 
  lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml bfcf16b997fc101e7d2904b9e5ebed5d1bdd480c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java ddfd777a77247ece953d11208086ea7f473179e1 
  lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 

Diff: https://reviews.apache.org/r/51332/diff/


Testing
-------


Thanks,

Rajat Khandelwal