You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/05/04 22:50:49 UTC

[GitHub] [beam] Abacn opened a new pull request, #26562: Remove never-worked githubPush trigger

Abacn opened a new pull request, #26562:
URL: https://github.com/apache/beam/pull/26562

   Closes #26561 ; Part of #26479
   
   * Increase Sickbay PostCommit trigger interval from 6h to daily
   
   * Increase Java RunnerV2 VR interval from 6h to 8h (the streaming test already runs 7h)
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536541238

   Run Python_Xlang_Gcp_Dataflow PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187666336


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   Makes sense, thanks for the explanation. Have you considered defining the value inside the closure? So as to be accessed with `jobDefinition.buildSchedule`? I just haven't seen a variable declared like this before in our repo and don't know if there's any downsides to it. 
   
   Up to you, I'll defer to your judgement here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187281880


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   instead of try catch block, can do something like 
   ```suggestion
       String buildSchedule = scope.hasProperty('buildSchedule')?.getProperty(scope) ?: 'H H/6 * * *'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187478468


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   This is a weird part of groovy. Tested that `getProperty('buildSchedule')` returns the string if previously set but `hasProperty('buildSchedule')` always returns false value. 
   
   refer to: https://stackoverflow.com/questions/17921490/hasproperty-returns-null (though the answer there was not super clear). Basically it seems hasProperty does not recognize the property dynamically added to the instance, but hasProperty does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536594144

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187478468


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   This is a weird part of groovy. Tested that `getProperty('buildSchedule')` returns the string if previously set but `hasProperty('buildSchedule')` always returns false value. 
   
   refer to: https://stackoverflow.com/questions/17921490/hasproperty-returns-null (though the answer there were not super clear). Basically it seems hasProperty does not recognize the property dynamically added to the instance, but hasProperty does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1535508824

   run seed job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1535502561

   run seed job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536529158

   run seed job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536540913

   Verified the schedule change works:
   
   <img width="632" alt="image" src="https://user-images.githubusercontent.com/8010435/236521523-7e4ec8d8-231e-4e3b-96de-b3abb6627089.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187683226


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   yeah, ideally PostcommitJobBuilder should just be designed as PrecommitJobBuilder where parameters can be set as a map-like constructor (as precommit job DSLs) then I would just need to add one more parameter there. However currently PostcommitJobBuilder does not quite follow a Builder pattern. Both constructor and its static method (postCommitJob) are used for assembling postcommit jobs. Opened #26588 addressing this as a future task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187683226


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   yeah, ideally PostcommitJobBuilder should just designed as PrecommitJobBuilder where parameters can be set as a map-like constructor (as precommit job DSLs) then I would just need to add one more parameter there. However currently PostcommitJobBuilder does not quite follow a Builder pattern. Both constructor and its static method (postCommitJob) are used for assembling postcommit jobs. Opened #26588 addressing this as a future task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1539163149

   Run Python_Runners PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536548463

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#26562](https://app.codecov.io/gh/apache/beam/pull/26562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0dc5874) into [master](https://app.codecov.io/gh/apache/beam/commit/5772bf74cbe556277976e4883b27e37b7a7e87f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5772bf7) will **increase** coverage by `0.90%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26562      +/-   ##
   ==========================================
   + Coverage   71.17%   72.08%   +0.90%     
   ==========================================
     Files         787      745      -42     
     Lines      103293   101203    -2090     
   ==========================================
   - Hits        73522    72954     -568     
   + Misses      28283    26789    -1494     
   + Partials     1488     1460      -28     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `81.13% <ø> (+1.26%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 92 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/26562/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536541113

   Run Python_Xlang_Gcp_Direct PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1536592888

   R: @ahmedabu98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on pull request #26562: Remove never-worked githubPush trigger

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #26562:
URL: https://github.com/apache/beam/pull/26562#issuecomment-1538158504

   Thanks for this change! The xlang GCP dataflow test time really did get cut in half; and direct now only takes a few minutes to run


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187622594


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   I see. I looked again at how buildSchedule is passed into this method, would it not be cleaner to create a new parameter in `PostcommitJobBuilder.postCommitJob()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187637856


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   Yeah I was considering this. The signature of static `postCommitJob` and `PostcommitJobBuilder` constructor both have the last parameter is a Closure so that they can be called in a special syntax `method(para1, para2) { closure }` and pass the code block in the braces as its last parameter. If I need to add the parameters then I need to add `buildSchedule` as the second last parameter. However the method is called in both `method(para1, para2) { closure }` and `method(para1, para2, ..., closure)` and for the later I need to specify buildSchedule because it is not the last parameter.
   
   Anyway it turns out that adding a parameter introduces more code change (and must breaks current callers) so I decided to use the existing scope



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #26562: Remove never-worked githubPush trigger

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26562:
URL: https://github.com/apache/beam/pull/26562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org