You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/08/22 17:30:18 UTC

[GitHub] [spark] peter-toth commented on pull request #37630: [SPARK-40193][SQL] Merge subquery plans with different filters

peter-toth commented on PR #37630:
URL: https://github.com/apache/spark/pull/37630#issuecomment-1688626745

   I've updated this PR, the latest version contains the discussed changes from theads of https://github.com/apache/spark/pull/42223:
   - I remoted the physical scan equality check to make this PR simpler,
   - merge is allowed only if the cost differences between the merged and original plans are low: https://github.com/apache/spark/pull/42223#issuecomment-1664916455
   
   cc @beliefer, @cloud-fan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org