You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/28 09:12:19 UTC
Review Request 71384: Passed down failures into resource provider
fatal handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-8400
https://issues.apache.org/jira/browse/MESOS-8400
Repository: mesos
Description
-------
In a follow-up patch we will surface failures up the stack.
Diffs
-----
src/resource_provider/storage/provider.cpp f180af8c17f735acb18029b6e4cf2942b5536bf4
Diff: https://reviews.apache.org/r/71384/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71384: Passed down failures into resource provider
fatal handler.
Posted by Jan Schlicht <ja...@d2iq.com>.
> On Sept. 3, 2019, 3:02 p.m., Jan Schlicht wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 268 (original), 268 (patched)
> > <https://reviews.apache.org/r/71384/diff/1/?file=2163044#file2163044line268>
> >
> > Let's not use `Failure` here, as this class is meant to represent a failed future. Use `string` instead.
I see that this is being using in https://reviews.apache.org/r/71385/. I'll remove this issue.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/#review217541
-----------------------------------------------------------
On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71384/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 11:12 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8400
> https://issues.apache.org/jira/browse/MESOS-8400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a follow-up patch we will surface failures up the stack.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp f180af8c17f735acb18029b6e4cf2942b5536bf4
>
>
> Diff: https://reviews.apache.org/r/71384/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71384: Passed down failures into resource provider
fatal handler.
Posted by Jan Schlicht <ja...@d2iq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/#review217541
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/storage/provider.cpp
Line 268 (original), 268 (patched)
<https://reviews.apache.org/r/71384/#comment304794>
Let's not use `Failure` here, as this class is meant to represent a failed future. Use `string` instead.
- Jan Schlicht
On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71384/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 11:12 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8400
> https://issues.apache.org/jira/browse/MESOS-8400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In a follow-up patch we will surface failures up the stack.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp f180af8c17f735acb18029b6e4cf2942b5536bf4
>
>
> Diff: https://reviews.apache.org/r/71384/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>