You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/05/27 05:09:30 UTC

Review Request 34694: UpgradeCatalog210 fails because older schemas used different FK names for host columns

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34694/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-11409
    https://issues.apache.org/jira/browse/AMBARI-11409


Repository: ambari


Description
-------

When upgrading Ambari from 1.7.0 to 2.0.0 to 2.1.0, it fails because in older schemas the FK names of columns related to the host_name changed over time.
UpgradeCatalog210 should include the older FK names, and perform a CASCADE DELETE on the hosts PK just for good measure.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java ace05ce 

Diff: https://reviews.apache.org/r/34694/diff/


Testing
-------

Reproduced the issue, and after patching ambari-server.jar was able to get the upgrade to get past the Hosts.

Unit Tests for UpgradeCatalog210 passed.


Thanks,

Alejandro Fernandez


Re: Review Request 34694: UpgradeCatalog210 fails because older schemas used different FK names for host columns

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34694/#review85344
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On May 26, 2015, 11:09 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34694/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 11:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-11409
>     https://issues.apache.org/jira/browse/AMBARI-11409
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When upgrading Ambari from 1.7.0 to 2.0.0 to 2.1.0, it fails because in older schemas the FK names of columns related to the host_name changed over time.
> UpgradeCatalog210 should include the older FK names, and perform a CASCADE DELETE on the hosts PK just for good measure.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java ace05ce 
> 
> Diff: https://reviews.apache.org/r/34694/diff/
> 
> 
> Testing
> -------
> 
> Reproduced the issue, and after patching ambari-server.jar was able to get the upgrade to get past the Hosts.
> 
> Unit Tests for UpgradeCatalog210 passed.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>