You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/03/03 13:30:55 UTC
Review Request 57287: LogSearch Portal UI Fails on Last Page
selection if logs were deleted in the meantime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300
Repository: ambari
Description
-------
If logs are deleted between the last screen generation and the clicking on the last page button an empty table comes up. The same happens if the user clicks on a page number which is no longer valid, as there are fewer logs since.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java a260ed0
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java d44b866
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 2dc0ef7
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 89873f3
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java f960250
Diff: https://reviews.apache.org/r/57287/diff/1/
Testing
-------
Tested on local cluster setting extra short time for the logs to expire.
Thanks,
Miklos Gergely
Re: Review Request 57287: LogSearch Portal UI Fails on Last Page
selection if logs were deleted in the meantime
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/#review167819
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
Line 86 (original), 86 (patched)
<https://reviews.apache.org/r/57287/#comment239796>
can we still use lastPage as a parameter? that means it would be better to change on the UI
- Oliver Szabo
On March 3, 2017, 1:30 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57287/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 1:30 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20300
> https://issues.apache.org/jira/browse/AMBARI-20300
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If logs are deleted between the last screen generation and the clicking on the last page button an empty table comes up. The same happens if the user clicks on a page number which is no longer valid, as there are fewer logs since.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java a260ed0
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java d44b866
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 2dc0ef7
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 89873f3
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java f960250
>
>
> Diff: https://reviews.apache.org/r/57287/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster setting extra short time for the logs to expire.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 57287: LogSearch Portal UI Fails on Last Page
selection if logs were deleted in the meantime
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/#review168033
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On March 3, 2017, 9:23 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57287/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 9:23 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20300
> https://issues.apache.org/jira/browse/AMBARI-20300
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If logs are deleted between the last screen generation and the clicking on the last page button an empty table comes up. The same happens if the user clicks on a page number which is no longer valid, as there are fewer logs since.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java d44b866
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 2dc0ef7
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 89873f3
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java f960250
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js c175397
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js 1066510
>
>
> Diff: https://reviews.apache.org/r/57287/diff/2/
>
>
> Testing
> -------
>
> Tested on local cluster setting extra short time for the logs to expire.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 57287: LogSearch Portal UI Fails on Last Page
selection if logs were deleted in the meantime
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
-----------------------------------------------------------
(Updated March 3, 2017, 9:23 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
fix branch to 2.5-cloud
Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300
Repository: ambari
Description
-------
If logs are deleted between the last screen generation and the clicking on the last page button an empty table comes up. The same happens if the user clicks on a page number which is no longer valid, as there are fewer logs since.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java d44b866
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 2dc0ef7
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 89873f3
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java f960250
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js c175397
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js 1066510
Diff: https://reviews.apache.org/r/57287/diff/2/
Testing
-------
Tested on local cluster setting extra short time for the logs to expire.
Thanks,
Miklos Gergely
Re: Review Request 57287: LogSearch Portal UI Fails on Last Page
selection if logs were deleted in the meantime
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57287/
-----------------------------------------------------------
(Updated March 3, 2017, 2:06 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
rename last page variable to lastPage
Bugs: AMBARI-20300
https://issues.apache.org/jira/browse/AMBARI-20300
Repository: ambari
Description
-------
If logs are deleted between the last screen generation and the clicking on the last page button an empty table comes up. The same happens if the user clicks on a page number which is no longer valid, as there are fewer logs since.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java d44b866
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 2dc0ef7
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 89873f3
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java f960250
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js c175397
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/TableLayout.js 1066510
Diff: https://reviews.apache.org/r/57287/diff/2/
Changes: https://reviews.apache.org/r/57287/diff/1-2/
Testing
-------
Tested on local cluster setting extra short time for the logs to expire.
Thanks,
Miklos Gergely