You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/16 04:04:24 UTC

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3247: [Feature][ui]Admin users can click to view doc.html or swagger-ui.html

dailidong commented on issue #3247:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3247#issuecomment-745749636


   > > Hi,
   > > I think it is a good feature to add `http://hostname:port/dolphinscheduler/doc.html` for admin and it is easy to implement.
   > > **Anyone who want to implement it , please leave a message.**
   > > `Noted`: What's the important is that the authority, and we should pay attention to the authority. For dev branch, I test and find anyone who have not logged in can reach the `http://xxx/dolphinscheduler/doc.html`.
   > > Suggest to control the permissions of the `swagger doc interface` although there is already has the permission check when user call the api.
   > 
   > I have implemented the UI part. As you said, `doc.html` or `swagger-ui.html` without user authentication, everyone can access if they know the connection, I am considering how to implement this part of authentication.
   
   I don't think API interface need user authentication, it's open API for everyone to use


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org