[GitHub] [pinot] walterddr commented on a diff in pull request #9479: Refactor and allow InstanceResponseBlock to delay generate DataTable

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9479:
URL: https://github.com/apache/pinot/pull/9479#discussion_r988364295


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/BaseResultsBlock.java:
##########
@@ -174,6 +177,21 @@ protected void attachMetadataToDataTable(DataTable dataTable) {
     metadata.put(MetadataKey.NUM_CONSUMING_SEGMENTS_PROCESSED.getName(),
         Integer.toString(_numConsumingSegmentsProcessed));
     metadata.put(MetadataKey.NUM_CONSUMING_SEGMENTS_MATCHED.getName(), Integer.toString(_numConsumingSegmentsMatched));
+    return metadata;
+  }
+
+  protected void attachMetadataToDataTable(DataTable dataTable) {

Review Comment:
   yes. i wanted to remove this. i am rethinking this is -->
   once the BaseResultBlock gets wrapped into an InstanceResponseBlock. everything other than the real data should be move into the instanceResponseBlock's member variable. and this should remain unchanged.
   
   where as the metadata in InstanceResponseBlock will get enriched with downstream logic. (metrics, error, warnings, etc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org