You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/09/04 20:29:18 UTC

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2722: GOBBLIN-865: Add feature that enables PK-chunking in partition

zxcware commented on a change in pull request #2722: GOBBLIN-865: Add feature that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r320960136
 
 

 ##########
 File path: gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
 ##########
 @@ -896,6 +928,43 @@ private void reinitializeBufferedReader() throws IOException, AsyncApiException
     }
   }
 
+  private List<JsonElement> fetchWithRetry(
 
 Review comment:
   If bulk api already does retry, can we remove the retry on our side? Application layer retry after api layer retries mostly won't change the error result if any.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services