[GitHub] [rocketmq] liyiwen3 opened a new pull request #1643: 并发问题

[GitBox <gi...@apache.org>]

liyiwen3 opened a new pull request #1643: 并发问题
URL: https://github.com/apache/rocketmq/pull/1643
 
 
   org.apache.rocketmq.common.ServiceThread
   
   public void wakeup() {
           if (hasNotified.compareAndSet(false, true)) {
               waitPoint.countDown(); // notify
           }
       }
   
       protected void waitForRunning(long interval) {
           if (hasNotified.compareAndSet(true, false)) {
               this.onWaitEnd();
               return;
           }//(1)
   
           //entry to wait
           waitPoint.reset();//（2）
   
           try {
               waitPoint.await(interval, TimeUnit.MILLISECONDS);
           } catch (InterruptedException e) {
               log.error("Interrupted", e);
           } finally {
               hasNotified.set(false);
               this.onWaitEnd();
           }
       }
   这段代码在并发环境下会有问题，假设线程a执行到（1）和（2）之间，然后现在线程b调用wakeup()，之后线程a执行 waitPoint.reset();，则之后在执行waitPoint.await(interval, TimeUnit.MILLISECONDS);的时候，线程a依旧会等待。 改变下waitPoint.reset();的位置可以修复该bug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services