You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/05 12:31:00 UTC
[jira] [Commented] (KAFKA-7477) Improve Streams close timeout
semantics
[ https://issues.apache.org/jira/browse/KAFKA-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639765#comment-16639765 ]
ASF GitHub Bot commented on KAFKA-7477:
---------------------------------------
nizhikov opened a new pull request #5747: KAFKA-7477
URL: https://github.com/apache/kafka/pull/5747
Second part of [KIP-358](https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times).
This changes based on [previous PR discussion](https://github.com/apache/kafka/pull/5682#discussion_r221473451)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Improve Streams close timeout semantics
> ---------------------------------------
>
> Key: KAFKA-7477
> URL: https://issues.apache.org/jira/browse/KAFKA-7477
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: John Roesler
> Assignee: Nikolay Izhikov
> Priority: Minor
> Labels: kip, newbie
>
> See [https://github.com/apache/kafka/pull/5682#discussion_r221473451]
> The current timeout semantics are a little "magical":
> * 0 means to block forever
> * negative numbers cause the close to complete immediately without checking the state
> I think this would make more sense:
> * reject negative numbers
> * make 0 just signal and return immediately (after checking the state once)
> * if I want to wait "forever", I can use {{ofYears(1)}} or {{ofMillis(Long.MAX_VALUE)}} or some other intuitively "long enough to be forever" value instead of a magic value.
>
> Part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)