[jira] [Resolved] (YARN-4959) MiniYARNCluster should implement AutoCloseable

["John Zhuge (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Zhuge resolved YARN-4959.
------------------------------
       Resolution: Not A Problem
    Fix Version/s: 2.7.0

Already supported because:
* {{MiniYARNCluster}} inherits from {{CompositeService}} => {{AbstractService}} => {{Service}} => {{Closeable}} => {{AutoCloseable}}.
* {{AbstractService.close}} calls {{stop}} which calls {{serviceStop}}.
* {{MiniYARNCluster}} performs cleanup in its overridden {{serviceStop}}

Thanks, [~boky01], for point it out in a comment for HDFS-10287.

> MiniYARNCluster should implement AutoCloseable
> ----------------------------------------------
>
>                 Key: YARN-4959
>                 URL: https://issues.apache.org/jira/browse/YARN-4959
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: John Zhuge
>            Priority: Trivial
>             Fix For: 2.7.0
>
>
> {{MiniYARNCluster}} should implement {{AutoCloseable}} in order to support [try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]. It will make test code a little cleaner and more reliable.
> Since {{AutoCloseable}} is only in Java 1.7 or later, this can not be backported to Hadoop version prior to 2.7.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)