You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "waterWang (via GitHub)" <gi...@apache.org> on 2026/08/17 09:47:42 UTC

[PR] fix: support java.util.Date in RecordConverter.convertLong [iceberg]

waterWang opened a new pull request, #17690:
URL: https://github.com/apache/iceberg/pull/17690

   Fixes #15344
   
   ### Problem
   When using Confluent Avro converter, timestamp-millis fields are deserialized as `java.util.Date` objects. `RecordConverter.convertLong()` only handles `Number` and `String`, causing `IllegalArgumentException: Cannot convert to long: java.util.Date`.
   
   ### Fix
   Add `Date` handling to `convertLong()` via `Date.getTime()` to extract epoch millis, matching the existing pattern used by `convertDateValue`, `convertTimeValue`, `convertOffsetDateTime`, and `convertLocalDateTime` which all handle `Date`.
   
   ### Testing
   - [x] Existing test suite passes locally
   - [x] New Date values are properly converted to long epoch millis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: support java.util.Date in RecordConverter.convertLong [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17690:
URL: https://github.com/apache/iceberg/pull/17690#issuecomment-5824571777

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: support java.util.Date in RecordConverter.convertLong [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17690:
URL: https://github.com/apache/iceberg/pull/17690#issuecomment-5723121816

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: support java.util.Date in RecordConverter.convertLong [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17690: fix: support java.util.Date in RecordConverter.convertLong
URL: https://github.com/apache/iceberg/pull/17690


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org