[jira] [Commented] (TAP5-1965) Replace use of Request.getContextPath() with a symbol defined at application startup

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491329#comment-13491329 ] 

Jochen Kemnade commented on TAP5-1965:
--------------------------------------

I think, the fix might not be entirely correct. In AssetPathConstructorImpl:59/60 [1], the context path is expected to end with a slash, which it doesn't. The ServletContext API [2] says that it starts with a slash but doesn't end with one. Currently, for a context "app" it produces paths like //appassets/...

[1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java;h=3d81b8f2d6b13693984c3ef716e28a96a39f3c10;hb=3d81b8f2d6b13693984c3ef716e28a96a39f3c10#l59
[2] http://docs.oracle.com/javaee/5/api/javax/servlet/ServletContext.html#getContextPath%28%29
                
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
>                 Key: TAP5-1965
>                 URL: https://issues.apache.org/jira/browse/TAP5-1965
>             Project: Tapestry 5
>          Issue Type: Task
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Howard M. Lewis Ship
>              Labels: fixed-in-5.4-js-rewrite
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira