You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/08 15:20:22 UTC
[GitHub] [skywalking] EvanLjp opened a new issue #5062: Add env config control when loading agent jar
EvanLjp opened a new issue #5062:
URL: https://github.com/apache/skywalking/issues/5062
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
in our department , a unified agent jar package will be used when Helm Chart package in all the services.
maybe .some service don't need so many detail when tracing. for example spring plugin.
however,other service need it.
nowadays.we cannot now control the loading of the unified Jars by reading environment variables.
so i want to add the feature. loading by env config.
for example:
/plugins has 5 jar
Optional way:
1. inclues: a.jar will only load a.jar
2.excludes: a.jar will load other 4 jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5062:
URL: https://github.com/apache/skywalking/issues/5062#issuecomment-655587491
How do you expert the option plugins?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #5062:
URL: https://github.com/apache/skywalking/issues/5062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5062:
URL: https://github.com/apache/skywalking/issues/5062#issuecomment-655596805
I hope it could work in this way
1. `include-plugins`. When this is activated(not null), then only these plugins should be loaded. Path should be `/plugins/xxx.jar`, `optional-plugins/yyy.jar` or `activations/zzz.jar`
1. `exclude-plugins`. This should be based on the default only, `plugins/` and `activations`.
What do you think about these policies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5062:
URL: https://github.com/apache/skywalking/issues/5062#issuecomment-655814577
> Is only when you don't use the option-plugins, the excludes works?
Yes and No. By reading your use case, you actually are looking for a solution for a unified base image. So, you could copy the all optional plugins into plugins, and use `excludes` to make things work.
Or, you should think again, whether `include` and `exclude` are both needed. I am feeling, `include` is required only. As that, I prefer this config called `activate-plugins`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5062:
URL: https://github.com/apache/skywalking/issues/5062#issuecomment-655605166
question:
/plugins/ has 20 jars
/optional-plugins/ has 10 jars
when need 8 jars in plugins and 2 jars in optional-plugins ,how it works?
1. include-plugins config 10 jars.
when need 10 jars in plugins and 2 jars in optional-plugins ,how it works?
1. include-plugins config 12 jars.
Is only when you don't use the option-plugins, the excludes works ?
maybe this is a good idea, user only care the plugins which is selected. So excludes status should be weakening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on issue #5062: Add env config control when loading agent jar
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5062:
URL: https://github.com/apache/skywalking/issues/5062#issuecomment-655593813
some plans:
(1) don't care option plugins.This will break now model.
the includes or excludes only work for plugins dir.
(2) work on option plugins.
1. all load plugins position and option plugins position.
2. includes work on option plugins dir , default is excludes all
3. excludes work on plugins dir , default is includes all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org