[GitHub] [iceberg] kbendick commented on pull request #3090: [SPARK] Add in config value needed in tests once Spark 3.2 is supported

[GitBox <gi...@apache.org>]

kbendick commented on pull request #3090:
URL: https://github.com/apache/iceberg/pull/3090#issuecomment-915698533


   I would set this everywhere, but it gets overridden in subclasses that instantiate their own SparkSession. So I've only set it for the one place I know that will need it.
   
   Possibly we should be instantiating SparkSessions in tests so that they pull down the configuration of their parents? We might see other fringe benefits of instantiating our spark sessions differently, but there could be drawbacks as well (less parallel testing perhaps). Will investigate. But it would be nice if configs were inherited from super classes that instantiate a spark session as almost all cases I've seen just apply the same configs (and maybe a few extra) on the spark session of tests in subclasses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org