You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/28 15:54:48 UTC
[GitHub] [apisix-helm-chart] gxthrj opened a new pull request #4: WIP: adjustments for APISIX 2.1 release
gxthrj opened a new pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4
Changes:
1. Add `namespace` for Kinds.
2. Explicit configure `allow_admin` in `configmap`, because the `allow_admin` in `config.default.yaml` is configured.
3. Adjust `etcd` default configuration.
4. Remove `plugins` field if there is no plugin list, so the plugin list in `config.default.yaml` will be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535038918
##########
File path: chart/apisix/templates/ingress.yaml
##########
@@ -25,6 +25,7 @@ apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: {{ $fullName }}
+ namespace: {{ .Release.Namespace }}
Review comment:
We can remove this first, and add it back when apisix-ingress-controller is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#issuecomment-738518637
> how about remove etcd binary file and use dependencies？
Ok, Apache also does not allow binary files in the project.
I will remove the etcd binary and add some command in README for dependeny installation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] ShiningRush commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535144505
##########
File path: chart/apisix/templates/service-gateway.yaml
##########
@@ -18,6 +18,7 @@ apiVersion: v1
kind: Service
Review comment:
Got it, hmmm, it is really too long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] ShiningRush commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534920448
##########
File path: chart/apisix/templates/tests/test-connection.yaml
##########
@@ -18,6 +18,7 @@ apiVersion: v1
kind: Pod
metadata:
name: "{{ include "apisix.fullname" . }}-test-connection"
+ namespace: {{ .Release.Namespace }}
Review comment:
We really need this pod? I think the health check is enough.
##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -72,9 +73,14 @@ data:
# disk_path: "/tmp/disk_cache_two"
# cache_levels: "1:2"
- # allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- # - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
- # - 172.17.0.0/24
+ allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
Review comment:
It is not a good design, we can not limit user config by predefined parameter.
Define a values parameter names `config`, then transform it's content to `config.yaml` would be better, it can give user full control to config.
##########
File path: chart/apisix/templates/ingress.yaml
##########
@@ -25,6 +25,7 @@ apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: {{ $fullName }}
+ namespace: {{ .Release.Namespace }}
Review comment:
`Ingress` required cluster install `ingress-controller`, k8s cluster does not install any implement about it by default, so this CRD will not work.
##########
File path: chart/apisix/templates/service-gateway.yaml
##########
@@ -18,6 +18,7 @@ apiVersion: v1
kind: Service
Review comment:
Can this service work well?I found that there are some problems:
- it not config `selector`, it will not bind to any pods
- no ports specified, it will not proxy any traffic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] ShiningRush commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534899386
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
Review comment:
chart version is different with application version, our chart is not validated by many production, it is not stable now, so `0.x.x` would be better. `2.1.1` tells people it already production ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535036956
##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -72,9 +73,14 @@ data:
# disk_path: "/tmp/disk_cache_two"
# cache_levels: "1:2"
- # allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- # - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
- # - 172.17.0.0/24
+ allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
Review comment:
Okay, we can do this in another issue #7 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] membphis commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534030123
##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
admin: edd1c9f034335f136f87ad84b625c8f1
viewer: 4054f7cf07e344346cd3f287985e76a2
+allow:
+ # The ip range for allowing access to Apache APISIX
+ ipList:
+ - 127.0.0.1/24
+
# APISIX plugins to be enabled
plugins:
- - example-plugin
- - limit-req
- - limit-count
- - limit-conn
- - key-auth
+ - api-breaker
+ - authz-keycloak
- basic-auth
- - prometheus
- - node-status
- - jwt-auth
- - zipkin
- - ip-restriction
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ - fault-injection
- grpc-transcode
- - serverless-pre-function
- - serverless-post-function
+ - hmac-auth
+ - http-logger
+ - ip-restriction
+ - jwt-auth
+ - kafka-logger
+ - key-auth
+ - limit-conn
+ - limit-count
+ - limit-req
+ - node-status
- openid-connect
+ - prometheus
+ - proxy-cache
+ - proxy-mirror
- proxy-rewrite
- redirect
+ - referer-restriction
+ - request-id
+ - request-validation
- response-rewrite
- - fault-injection
+ - serverless-post-function
+ - serverless-pre-function
+ - sls-logger
+ - syslog
+ - tcp-logger
- udp-logger
+ - uri-blocker
- wolf-rbac
- - proxy-cache
- - tcp-logger
- - proxy-mirror
- - kafka-logger
- - cors
+ - zipkin
stream_plugins:
Review comment:
ditto
##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
admin: edd1c9f034335f136f87ad84b625c8f1
viewer: 4054f7cf07e344346cd3f287985e76a2
+allow:
+ # The ip range for allowing access to Apache APISIX
+ ipList:
+ - 127.0.0.1/24
+
# APISIX plugins to be enabled
plugins:
Review comment:
I think we can delete `plugins`, use the default list should be enough
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 1.16.0
+appVersion: 2.1.0
+
+dependencies:
+ - name: etcd
+ version: 5.2.1
Review comment:
`5.2.1`? I am confused with this version value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535043646
##########
File path: chart/apisix/templates/service-gateway.yaml
##########
@@ -18,6 +18,7 @@ apiVersion: v1
kind: Service
Review comment:
`selector` is in the end of this file. It is defined in `_helpers.tpl`
`ports` is defined, the value is `gateway` in values.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] moonming merged pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534035254
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 1.16.0
+appVersion: 2.1.0
+
+dependencies:
+ - name: etcd
+ version: 5.2.1
Review comment:
This is etcd Charts version ，not the version of etcd.
It is Chart dependencies here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534956084
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
Review comment:
I am going to use the third minor version number as the helm version, keeping the first two consistent with APISIX.
e.g. 2.1.x for chart version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r536956689
##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -137,12 +143,19 @@ data:
# ipc_shared_dict: 100m # custom shared cache, format: `cache-key: cache-size`
etcd:
+ {{- if .Values.etcd.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ - "http://{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.cluster.local:2379"
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534041617
##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
admin: edd1c9f034335f136f87ad84b625c8f1
viewer: 4054f7cf07e344346cd3f287985e76a2
+allow:
+ # The ip range for allowing access to Apache APISIX
+ ipList:
+ - 127.0.0.1/24
+
# APISIX plugins to be enabled
plugins:
- - example-plugin
- - limit-req
- - limit-count
- - limit-conn
- - key-auth
+ - api-breaker
+ - authz-keycloak
- basic-auth
- - prometheus
- - node-status
- - jwt-auth
- - zipkin
- - ip-restriction
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ - fault-injection
- grpc-transcode
- - serverless-pre-function
- - serverless-post-function
+ - hmac-auth
+ - http-logger
+ - ip-restriction
+ - jwt-auth
+ - kafka-logger
+ - key-auth
+ - limit-conn
+ - limit-count
+ - limit-req
+ - node-status
- openid-connect
+ - prometheus
+ - proxy-cache
+ - proxy-mirror
- proxy-rewrite
- redirect
+ - referer-restriction
+ - request-id
+ - request-validation
- response-rewrite
- - fault-injection
+ - serverless-post-function
+ - serverless-pre-function
+ - sls-logger
+ - syslog
+ - tcp-logger
- udp-logger
+ - uri-blocker
- wolf-rbac
- - proxy-cache
- - tcp-logger
- - proxy-mirror
- - kafka-logger
- - cors
+ - zipkin
stream_plugins:
Review comment:
I keep it here is to leave a configuration item(placeholder) for users who wanted to use plugins belong themself.
In fact, we can indeed set the plug-in list to be empty, I made it compatible.
But I am not sure if we should set the plugin list empty by default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#issuecomment-737091680
> why add etcd bin file to repo？
This is the helm way for installing dependencies.
[We can find Postgresql in Kong Charts](https://github.com/Kong/charts/tree/main/charts/kong/charts)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534035822
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 1.16.0
+appVersion: 2.1.0
+
+dependencies:
+ - name: etcd
+ version: 5.2.1
Review comment:
In Charts, version is for Charts, appVersion is for the application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] membphis commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534905352
##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
admin: edd1c9f034335f136f87ad84b625c8f1
viewer: 4054f7cf07e344346cd3f287985e76a2
+allow:
+ # The ip range for allowing access to Apache APISIX
+ ipList:
+ - 127.0.0.1/24
+
# APISIX plugins to be enabled
plugins:
Review comment:
only comment should be enough if you want the user to know how to use it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] lilien1010 commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534908301
##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -137,12 +143,19 @@ data:
# ipc_shared_dict: 100m # custom shared cache, format: `cache-key: cache-size`
etcd:
+ {{- if .Values.etcd.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ - "http://{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.cluster.local:2379"
Review comment:
I think we can change `cluster.local` into vaules.yaml, and make it configurable ? since some of the K8S cluster name is not by default
```
{{- if .Values.etcd.enabled }}
- "http://{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.{{ .Values.gateway.k8s_domain }}:{{ .Values.etcd.port }}"
{{- else }}
- {{ .Values.etcd.host }}
{{- end }}
```
##########
File path: chart/apisix/templates/deployment.yaml
##########
@@ -77,13 +78,6 @@ spec:
subPath: config.yaml
resources:
{{- toYaml .Values.resources | nindent 12 }}
Review comment:
need make sure etcd is live,before apisix start
```
initContainers:
- name: wait-etcd
image: busybox:1.28
command: ['sh', '-c', "until nc -z {{ .Release.Name }}-etcd-0.{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.{{ .Values.gateway.k8s_domain }} {{ .Values.etcd.port }}; do echo waiting for etcd `date`; sleep 2; done;"]
# - name: dnsmasq
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r536961385
##########
File path: chart/apisix/templates/deployment.yaml
##########
@@ -77,13 +78,6 @@ spec:
subPath: config.yaml
resources:
{{- toYaml .Values.resources | nindent 12 }}
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535040004
##########
File path: chart/apisix/templates/tests/test-connection.yaml
##########
@@ -18,6 +18,7 @@ apiVersion: v1
kind: Pod
metadata:
name: "{{ include "apisix.fullname" . }}-test-connection"
+ namespace: {{ .Release.Namespace }}
Review comment:
This not needed. removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r535036956
##########
File path: chart/apisix/templates/configmap.yaml
##########
@@ -72,9 +73,14 @@ data:
# disk_path: "/tmp/disk_cache_two"
# cache_levels: "1:2"
- # allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- # - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
- # - 172.17.0.0/24
+ allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
Review comment:
Okay, we can do this config.yaml configuration in another issue #7 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534041206
##########
File path: chart/apisix/values.yaml
##########
@@ -95,34 +102,51 @@ admin:
admin: edd1c9f034335f136f87ad84b625c8f1
viewer: 4054f7cf07e344346cd3f287985e76a2
+allow:
+ # The ip range for allowing access to Apache APISIX
+ ipList:
+ - 127.0.0.1/24
+
# APISIX plugins to be enabled
plugins:
Review comment:
I keep it here is to leave a configuration item(placeholder) for users who wanted to use plugins belong themself.
In fact, we can indeed set the plug-in list to be empty, I made it compatible.
But I am not sure if we should set the plugin list empty by default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] lilien1010 commented on pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#issuecomment-737749869
how about remove etcd binary file and use dependencies？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #4: feat: adjustments for APISIX 2.1 release
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #4:
URL: https://github.com/apache/apisix-helm-chart/pull/4#discussion_r534970980
##########
File path: chart/apisix/Chart.yaml
##########
@@ -31,9 +31,16 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 2.1.0
Review comment:
Ok, use 0.x.x first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org