You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by jw...@apache.org on 2002/07/16 07:25:44 UTC

cvs commit: apr/poll/unix pollacc.c

jwoolley    2002/07/15 22:25:44

  Modified:    poll/unix pollacc.c
  Log:
  Nuke a warning due to a function that should have been static AFAICT:
  
  pollacc.c:78: warning: no previous prototype for `find_poll_sock'
  
  Revision  Changes    Path
  1.2       +1 -1      apr/poll/unix/pollacc.c
  
  Index: pollacc.c
  ===================================================================
  RCS file: /home/cvs/apr/poll/unix/pollacc.c,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -d -u -r1.1 -r1.2
  --- pollacc.c	11 Jul 2002 15:32:18 -0000	1.1
  +++ pollacc.c	16 Jul 2002 05:25:44 -0000	1.2
  @@ -74,7 +74,7 @@
       return APR_SUCCESS;
   }
   
  -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset, apr_socket_t *sock)
  +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, apr_socket_t *sock)
   {
       apr_pollfd_t *curr = aprset;
       
  
  
  

Re: cvs commit: apr/poll/unix pollacc.c

Posted by rb...@apache.org.
On 16 Jul 2002 jwoolley@apache.org wrote:

> jwoolley    2002/07/15 22:25:44
> 
>   Modified:    poll/unix pollacc.c
>   Log:
>   Nuke a warning due to a function that should have been static AFAICT:
>   
>   pollacc.c:78: warning: no previous prototype for `find_poll_sock'

Yep should have been a static, only used for backwards compat.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
550 Jean St
Oakland CA 94610
-------------------------------------------------------------------------------


Re: cvs commit: apr/poll/unix pollacc.c

Posted by rb...@apache.org.
On 16 Jul 2002 jwoolley@apache.org wrote:

> jwoolley    2002/07/15 22:25:44
> 
>   Modified:    poll/unix pollacc.c
>   Log:
>   Nuke a warning due to a function that should have been static AFAICT:
>   
>   pollacc.c:78: warning: no previous prototype for `find_poll_sock'

Yep should have been a static, only used for backwards compat.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
550 Jean St
Oakland CA 94610
-------------------------------------------------------------------------------


Re: Namespace protection [was cvs commit: apr/poll/unix pollacc.c]

Posted by Jeff Trawick <tr...@attglobal.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:

> This raises a real question.  We have several tools on Win32, including
> the simple Depends.exe utility, that let you review all symbols exported
> from a binary.  Would someone on Unix mind dumping the list of all
> exported non-namespace-protected symbols for review and cleanup?

Here is what I see with current head on AIX...

apr-util:

% dump -Tv libaprutil.so | grep EXP | grep -v apr_ | awk  '{print $8;}'
grain                   (fixed just a minute ago)
sdbm_nullitem
sdbm__splpage
sdbm__fitpair
sdbm__getnkey
sdbm__chkpage
sdbm_hash
sdbm__delpair
sdbm__duppair
sdbm__putpair
sdbm__getpair

apr:

(none)

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Namespace protection [was cvs commit: apr/poll/unix pollacc.c]

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 07:37 AM 7/16/2002, Sander Striker wrote:
> > From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]
> > Sent: 16 July 2002 14:25
>
> > At 12:25 AM 7/16/2002, jwoolley@apache.org wrote:
> > >   --- pollacc.c 11 Jul 2002 15:32:18 -0000      1.1
> > >   +++ pollacc.c 16 Jul 2002 05:25:44 -0000      1.2
> > >   -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset,
> > > apr_socket_t *sock)
> > >   +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, 
> apr_socket_t
> > > *sock)
> >
> > Ummm... -1.  You just exported a symbol without namespace protection ;-)
>
>No, he just _un_exported a symbol without namespace protection.

Teach me to try to read email without coffee in hand, yes sir.

Thanks for the right fix, Cliff :-)

This raises a real question.  We have several tools on Win32, including
the simple Depends.exe utility, that let you review all symbols exported
from a binary.  Would someone on Unix mind dumping the list of all
exported non-namespace-protected symbols for review and cleanup?

Bill



Re: cvs commit: apr/poll/unix pollacc.c

Posted by Cliff Woolley <jw...@virginia.edu>.
On Tue, 16 Jul 2002, Cliff Woolley wrote:

> Uhh... What Sander said.  How is my commit exporting a symbol?  It's
> *UN*exporting the symbol.  :-)

Ahh, I see you already responded to this under a different subject line.
Looks like both of us need our coffee.  :)


Re: cvs commit: apr/poll/unix pollacc.c

Posted by Cliff Woolley <jw...@virginia.edu>.
On Tue, 16 Jul 2002, William A. Rowe, Jr. wrote:

> At 12:25 AM 7/16/2002, jwoolley@apache.org wrote:
> >jwoolley    2002/07/15 22:25:44
> >
> >   Modified:    poll/unix pollacc.c
> >   Log:
> >   Nuke a warning due to a function that should have been static AFAICT:
> >
> >   pollacc.c:78: warning: no previous prototype for `find_poll_sock'
> >
> >   --- pollacc.c 11 Jul 2002 15:32:18 -0000      1.1
> >   +++ pollacc.c 16 Jul 2002 05:25:44 -0000      1.2
> >   @@ -74,7 +74,7 @@
> >        return APR_SUCCESS;
> >    }
> >
> >   -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset,
> > apr_socket_t *sock)
> >   +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, apr_socket_t
> > *sock)
>
> Ummm... -1.  You just exported a symbol without namespace protection ;-)

Uhh... What Sander said.  How is my commit exporting a symbol?  It's
*UN*exporting the symbol.  :-)

--Cliff


RE: cvs commit: apr/poll/unix pollacc.c

Posted by Sander Striker <st...@apache.org>.
> From: William A. Rowe, Jr. [mailto:wrowe@rowe-clan.net]
> Sent: 16 July 2002 14:25

> At 12:25 AM 7/16/2002, jwoolley@apache.org wrote:
> >jwoolley    2002/07/15 22:25:44
> >
> >   Modified:    poll/unix pollacc.c
> >   Log:
> >   Nuke a warning due to a function that should have been static AFAICT:
> >
> >   pollacc.c:78: warning: no previous prototype for `find_poll_sock'
> >
> >   --- pollacc.c 11 Jul 2002 15:32:18 -0000      1.1
> >   +++ pollacc.c 16 Jul 2002 05:25:44 -0000      1.2
> >   @@ -74,7 +74,7 @@
> >        return APR_SUCCESS;
> >    }
> >
> >   -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset, 
> > apr_socket_t *sock)
> >   +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, apr_socket_t 
> > *sock)
> 
> Ummm... -1.  You just exported a symbol without namespace protection ;-)
> 
> Bill

No, he just _un_exported a symbol without namespace protection.

Sander


Re: cvs commit: apr/poll/unix pollacc.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 12:25 AM 7/16/2002, jwoolley@apache.org wrote:
>jwoolley    2002/07/15 22:25:44
>
>   Modified:    poll/unix pollacc.c
>   Log:
>   Nuke a warning due to a function that should have been static AFAICT:
>
>   pollacc.c:78: warning: no previous prototype for `find_poll_sock'
>
>   --- pollacc.c 11 Jul 2002 15:32:18 -0000      1.1
>   +++ pollacc.c 16 Jul 2002 05:25:44 -0000      1.2
>   @@ -74,7 +74,7 @@
>        return APR_SUCCESS;
>    }
>
>   -APR_DECLARE(apr_pollfd_t*) find_poll_sock(apr_pollfd_t *aprset, 
> apr_socket_t *sock)
>   +static apr_pollfd_t *find_poll_sock(apr_pollfd_t *aprset, apr_socket_t 
> *sock)

Ummm... -1.  You just exported a symbol without namespace protection ;-)

Bill